Skip to content

[dialogflow] fix: marking a test with flaky #3671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2020
Merged

[dialogflow] fix: marking a test with flaky #3671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10cd0a1
[dialogflow] fix: marking a test with flaky
May 2, 2020
f4dcdc8
Merge branch 'master' into fix-dialogflow
May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dialogflow/cloud-client/create_document_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ def setup_teardown():
client.delete_knowledge_base(knowledge_base_path, force=True)


@pytest.mark.flaky(max_runs=3, min_passes=1)
def test_create_document(capsys):
document_management.create_document(
PROJECT_ID, pytest.KNOWLEDGE_BASE_ID, DOCUMENT_DISPLAY_NAME,
Expand Down
2 changes: 1 addition & 1 deletion dialogflow/cloud-client/document_management.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def create_document(project_id, knowledge_base_id, display_name, mime_type,

response = client.create_document(knowledge_base_path, document)
print('Waiting for results...')
document = response.result(timeout=90)
document = response.result(timeout=120)
print('Created Document:')
print(' - Display Name: {}'.format(document.display_name))
print(' - Knowledge ID: {}'.format(document.name))
Expand Down
1 change: 1 addition & 0 deletions dialogflow/cloud-client/requirements-test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
pytest==5.3.2
flaky==3.6.1