Invoke-IcingaCheckUptime not workling correct

[puseidr]

Version: 1.5.0

the cmdlets is not working (correctly) anymore.

the check should be critical when the update is lower than 12h and warning when its lower than 24h, so the old command was:

Invoke-IcingaCheckUptime -Warning '24h: -Critical 12h:

but since 1.5.0 the output is:

[CRITICAL] System Uptime: 327.99d [CRITICAL] System Uptime (327.99d)
\_ [CRITICAL] System Uptime: 327.99d is lower than threshold 12h
| 'system_uptime'=2.833848E+07s;86400:;43200:
2

even the performancedate is messed up

i thought, maybe you siwtched the logic for the check so i've tested without the colon ( : ) but the output doesn't make any sense for me:

PS C:\Windows\system32> Invoke-IcingaCheckUptime -verbosity 3 -Critical 5d
[OK] System Uptime: 327.99d (All must be [OK])
\_ [OK] Last Boot: 07/10/2020 11:20:27
\_ [OK] System Uptime: 327.99d
| 'system_uptime'=2.833808E+07s;;432000
0
PS C:\Windows\system32> Invoke-IcingaCheckUptime -verbosity 3 -Critical 500d
[OK] System Uptime: 327.99d (All must be [OK])
\_ [OK] Last Boot: 07/10/2020 11:20:27
\_ [OK] System Uptime: 327.99d
| 'system_uptime'=2.833809E+07s;;43200000
0
PS C:\Windows\system32> Invoke-IcingaCheckUptime -verbosity 3 -warning 500d
[OK] System Uptime: 327.99d (All must be [OK])
\_ [OK] Last Boot: 07/10/2020 11:20:27
\_ [OK] System Uptime: 327.99d
| 'system_uptime'=2.83381E+07s;43200000;
0
PS C:\Windows\system32> Invoke-IcingaCheckUptime -verbosity 3 -warning 5d
[OK] System Uptime: 327.99d (All must be [OK])
\_ [OK] Last Boot: 07/10/2020 11:20:27
\_ [OK] System Uptime: 327.99d
| 'system_uptime'=2.83381E+07s;432000;

it is always "OK" even if your thresholds are lower or higher then the current value

[puseidr]

Oh this looks like a bug only for servers running for a long time, i've go 2 Servers with an uptime of 320+ days. On all other servers the plugin output is correct

[LordHepipud]

This is an interesting issue. I assume we run in some sort of overflow for the uptime calculation.

Can you please use the following commands on of the these systems:

Use-Icinga;
$WindowsData = Get-IcingaWindows;
$WindowsData.windows.metadata.Uptime

and share the uptime output? I assume something is wrong here.

[puseidr]

A server with 328 days uptime:

PS C:\Windows\system32> Use-Icinga;
PS C:\Windows\system32> $WindowsData = Get-IcingaWindows;
PS C:\Windows\system32> $WindowsData.windows.metadata.Uptime

Name                           Value
----                           -----
value                          28344078,1113674
raw                            10.07.2020 11:20:27

and a server with 339 days uptime:

PS C:\Windows\system32> Use-Icinga;
PS C:\Windows\system32> $WindowsData = Get-IcingaWindows;
PS C:\Windows\system32> $WindowsData.windows.metadata.Uptime

Name                           Value
----                           -----
value                          29294102,0648933
raw                            29.06.2020 11:27:49

[LordHepipud]

Can you please test the linked PR for the Framework and verify if this resolves the issue?
It would also be great if you could check your other configured checks with thresholds, if there are any other issues remaining or if everything works as expected then.

[puseidr]

the PR seems to fix the issue and the other checks are still working.
i cant see any negative side effects :)