Skip to content

Fix: Removes String.Builder output while creating new components #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Fix: Removes String.Builder output while creating new components #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions doc/100-General/10-Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ documentation before upgrading to a new release.

Released closed milestones can be found on [GitHub](https://github.com/Icinga/icinga-powershell-framework/milestones?state=closed).

## 1.8.0 (2022-02-08)

[Issue and PRs](https://github.com/Icinga/icinga-powershell-framework/milestone/19?closed=1)

### Bugfixes

* [#398](https://github.com/Icinga/icinga-powershell-framework/pull/398) Fixes String.Builder object output, while creating new components by using `New-IcingaForWindowsComponent`

## 1.7.0 (2021-11-09)

[Issue and PRs](https://github.com/Icinga/icinga-powershell-framework/milestone/16?closed=1)
Expand Down
10 changes: 5 additions & 5 deletions lib/core/dev/Write-IcingaForWindowsComponentManifest.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,17 +50,17 @@ function Write-IcingaForWindowsComponentManifest()
[int]$CurrentIndex = 0;
foreach ($module in $Value) {
$CurrentIndex += 1;
$ContentString.Append('@{ ');
$ContentString.Append('@{ ') | Out-Null;

foreach ($dependency in $module.Keys) {
$DependencyValue = $module[$dependency];

$ContentString.Append([string]::Format("{0} = '{1}'; ", $dependency, $DependencyValue));
$ContentString.Append([string]::Format("{0} = '{1}'; ", $dependency, $DependencyValue)) | Out-Null;
}
$ContentString.Append('}');
$ContentString.Append('}') | Out-Null;

if ($CurrentIndex -ne $Value.Count) {
$ContentString.Append(",`r`n ");
$ContentString.Append(",`r`n ") | Out-Null;
}
}

Expand All @@ -73,7 +73,7 @@ function Write-IcingaForWindowsComponentManifest()
Write-IcingaFileSecure -File (Join-Path -Path $ModuleDir -ChildPath ([string]::Format('{0}.psd1', $ModuleName))) -Value $ManifestFileData;
}

$ContentString.Clear();
$ContentString.Clear() | Out-Null;

[array]$ManifestContent = Get-Content -Path (Join-Path -Path $ModuleDir -ChildPath ([string]::Format('{0}.psd1', $ModuleName)));

Expand Down