From f7fa6c2389cb059715a3504c0efcb5c13cd8cc4a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lorenz=20K=C3=A4stle?= <12514511+RincewindsHat@users.noreply.github.com> Date: Wed, 30 Oct 2024 17:47:49 +0100 Subject: [PATCH 1/2] Set maximum cache duration for service daemons to the right value This commit sets the maximum duration for cached data for service daemons to the proper amount. Previously it was multiplied by 60, probably a typo from a time when the assigned value was in minutes and not in seconds directly. Therefore the value was 60 times to high which leads to a massive amount of cached data which drags down the performance significantly. --- .../tools/New-IcingaServiceCheckDaemonEnvironment.psm1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/daemons/ServiceCheckDaemon/tools/New-IcingaServiceCheckDaemonEnvironment.psm1 b/lib/daemons/ServiceCheckDaemon/tools/New-IcingaServiceCheckDaemonEnvironment.psm1 index fce66685..34266e21 100644 --- a/lib/daemons/ServiceCheckDaemon/tools/New-IcingaServiceCheckDaemonEnvironment.psm1 +++ b/lib/daemons/ServiceCheckDaemon/tools/New-IcingaServiceCheckDaemonEnvironment.psm1 @@ -47,7 +47,7 @@ function New-IcingaServiceCheckDaemonEnvironment() } } - $Global:Icinga.Private.Daemons.ServiceCheck.MaxTimeInSeconds = $Global:Icinga.Private.Daemons.ServiceCheck.MaxTime * 60; + $Global:Icinga.Private.Daemons.ServiceCheck.MaxTimeInSeconds = $Global:Icinga.Private.Daemons.ServiceCheck.MaxTime; if ($Global:Icinga.Private.Scheduler.CheckData.ContainsKey($CheckCommand) -eq $FALSE) { $Global:Icinga.Private.Scheduler.CheckData.Add( From 7f02cf5fd0ceb2b71b92d900dac7c4ddbb684b1a Mon Sep 17 00:00:00 2001 From: Lord Hepipud Date: Fri, 24 Jan 2025 16:47:44 +0100 Subject: [PATCH 2/2] Updates changelog --- doc/100-General/10-Changelog.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/doc/100-General/10-Changelog.md b/doc/100-General/10-Changelog.md index 3430f943..0e401a97 100644 --- a/doc/100-General/10-Changelog.md +++ b/doc/100-General/10-Changelog.md @@ -7,6 +7,12 @@ documentation before upgrading to a new release. Released closed milestones can be found on [GitHub](https://github.com/Icinga/icinga-powershell-framework/milestones?state=closed). +## 1.13.0 (2025-01-30) + +### Bugfixes + +* [#759](https://github.com/Icinga/icinga-powershell-framework/pull/759) Fixes maximum cache duration for service daemons to the right value + ## 1.13.0 Beta-2 (2024-09-19) [Issues and PRs](https://github.com/Icinga/icinga-powershell-framework/milestone/36)