Add Single Logout support to examples and fix some bugs #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 3, 2014 14:23
This is according to the SAML2 spec, section 4.1.2.
erickt
force-pushed
the
logout
branch
3 times, most recently
from
1614e94 to
c6f0fe3
Compare
rohe
pushed a commit
that referenced
this pull request
Nov 10, 2014
Add Single Logout support to examples and fix some bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As best as I can tell, I've gotten Single Logout Service working with the example SP and IdP. I've tested against Shibboleth, so I think I've gotten the protocol working correctly. Along the way, I turned on signing logout requests in the example as it's possible to configure Shibboleth to require signing. I haven't added any unit tests though.