Skip to content

Conversation

@NetZissou
Copy link
Contributor

Summary

  • Added Dataset & Model cards from ABC.
  • Incorporated collapsible widgets to include the template file and download links for Imageomics and ABC.

{72E41632-5E1A-4E2E-9E1C-3BD3D968F744}

{5C957667-766D-4859-B90E-D3B3EF02BAF0}

Note

The "Download Template" link for ABC templates will only become functional after this merge because the templates do not currently exist in the main branch.

Linked Issue

Closes #16

@NetZissou NetZissou requested a review from egrace479 January 27, 2025 21:12
Ref #16: added dataset and model cards from ABC

Ref #16: added collapsible widgets and download links for dataset & model cards
Copy link
Member

@egrace479 egrace479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple preliminary suggestions. I want it to be clear that these are two distinct cards in each category (one for Imageomics and one for ABC) so they pay attention to copy the right one.

@egrace479
Copy link
Member

egrace479 commented Feb 17, 2025

I know we currently have a redirect to raw under the download links, but @NetZissou, can you try to get an actual download link for these? Otherwise, point to it on GitHub so they have a download button there. If linking to GH, then I'd also update the link to say "Download template from GitHub". Thanks!

Screenshot 2025-02-17 at 11 17 36 AM

Copy link
Member

@egrace479 egrace479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the description on the template intro page to include ABC as well. Please read it over before merging.

@egrace479 egrace479 requested a review from gwtaylor February 20, 2025 19:18
Copy link
Collaborator

@gwtaylor gwtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +207 to +245
## Citation
[More Information Needed]

**BibTeX:**
<!--
If you want to include BibTex, replace "<>"s with your info
**Data**
```
@misc{<ref_code>,
author = {<author1 and author2>},
title = {<title>},
year = {<year>},
url = {https://huggingface.co/datasets/ABC-Center/<dataset_name>},
doi = {<doi once generated>},
publisher = {Hugging Face}
}
```
-for an associated paper:
**Paper**
```
@article{<ref_code>,
title = {<title>},
author = {<author1 and author2>},
journal = {<journal_name>},
year = <year>,
url = {<DOI_URL>},
doi = {<DOI>}
}
```
-->

<!---
If the data is modified from another source, add the following.
Please be sure to also cite the original data source(s):
<citation>
-->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed we are using BibTeX for citation (which is what I am used to). But I learned about the CITATION.cff file from the Imageomics Guide, specifically the GitHub Repo Guide. Does it make sense to standardize to one or the other, or have you already considered this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not realize that CITATION.cff worked on Hugging Face, but it seems (Select "Cite this dataset" under the DOI on this repo) that including one may override the auto-generated DOI citation (e.g., on TOL-10M). In which case, I think it's a good idea to include for HF as well.

I still think including the BibTeX is useful since it will provide pre-formatted version of all citations (the actual repo, paper(s), references, etc.), but if simply including a CITATION.cff ensures proper citation dropdown when a DOI is generated, that's great.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting!
I agree that including the BibTeX is still useful.

@NetZissou NetZissou merged commit c0a5df9 into main Feb 24, 2025
@NetZissou NetZissou deleted the feature/templates branch February 24, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update template pages

4 participants