Skip to content

Commit e0fd17f

Browse files
fix: feature flag listener
1 parent a09e8e1 commit e0fd17f

File tree

4 files changed

+8
-13
lines changed

4 files changed

+8
-13
lines changed

src/modules/Instabug.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -592,8 +592,8 @@ export const _registerW3CFlagsChangeListener = (
592592
isW3CaughtHeaderEnabled: boolean;
593593
}) => void,
594594
) => {
595-
emitter.addListener(NativeEvents.ON_W3C_FLAGS_CHANE, (payload) => {
595+
emitter.addListener(NativeEvents.ON_W3C_FLAGS_CHANGE, (payload) => {
596596
handler(payload);
597597
});
598-
NativeInstabug.registerW3CFlagsChangeListener(handler);
598+
NativeInstabug.registerW3CFlagsChangeListener();
599599
};

src/native/NativeInstabug.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -145,20 +145,14 @@ export interface InstabugNativeModule extends NativeModule {
145145
isW3CaughtHeaderEnabled(): Promise<boolean>;
146146

147147
// W3C Feature Flags Listener for Android
148-
registerW3CFlagsChangeListener(
149-
handler: (payload: {
150-
isW3ExternalTraceIDEnabled: boolean;
151-
isW3ExternalGeneratedHeaderEnabled: boolean;
152-
isW3CaughtHeaderEnabled: boolean;
153-
}) => void,
154-
): void;
148+
registerW3CFlagsChangeListener(): void;
155149
}
156150

157151
export const NativeInstabug = NativeModules.Instabug;
158152

159153
export enum NativeEvents {
160154
PRESENDING_HANDLER = 'IBGpreSendingHandler',
161-
ON_W3C_FLAGS_CHANE = 'IBGOnNewW3CFlagsUpdateReceivedCallback',
155+
ON_W3C_FLAGS_CHANGE = 'IBGOnNewW3CFlagsUpdateReceivedCallback',
162156
}
163157

164158
export const emitter = new NativeEventEmitter(NativeInstabug);

src/utils/FeatureFlags.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { NativeInstabug } from '../native/NativeInstabug';
2+
import { _registerW3CFlagsChangeListener } from '../modules/Instabug';
23

34
export const FeatureFlags = {
45
isW3ExternalTraceID: () => NativeInstabug.isW3ExternalTraceIDEnabled(),
@@ -7,7 +8,7 @@ export const FeatureFlags = {
78
};
89

910
export const registerW3CFlagsListener = () => {
10-
NativeInstabug.registerW3CFlagsChangeListener(
11+
_registerW3CFlagsChangeListener(
1112
(res: {
1213
isW3ExternalTraceIDEnabled: boolean;
1314
isW3ExternalGeneratedHeaderEnabled: boolean;

test/modules/Instabug.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -787,9 +787,9 @@ describe('Instabug Module', () => {
787787
it('should invoke callback on emitting the event IBGOnNewW3CFlagsUpdateReceivedCallback', () => {
788788
const callback = jest.fn();
789789
Instabug._registerW3CFlagsChangeListener(callback);
790-
emitter.emit(NativeEvents.ON_W3C_FLAGS_CHANE);
790+
emitter.emit(NativeEvents.ON_W3C_FLAGS_CHANGE);
791791

792-
expect(emitter.listenerCount(NativeEvents.ON_W3C_FLAGS_CHANE)).toBe(1);
792+
expect(emitter.listenerCount(NativeEvents.ON_W3C_FLAGS_CHANGE)).toBe(1);
793793
expect(callback).toHaveBeenCalled();
794794
});
795795
});

0 commit comments

Comments
 (0)