Merge pull request #5034 from yurickyh/fix-for-issue-5019

"Set up general fields" character check not correct & alphabetical ordering

Author: Siedlerchr

CHANGELOG.md

@@ -66,6 +66,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
 - We added an option on the Linked File Viewer to rename the attached file of an entry directly on the JabRef. [#4844](https://github.com/JabRef/jabref/issues/4844)
 - We added an option in the preference dialog box that allows user to enable helpful tooltips.[#3599](https://github.com/JabRef/jabref/issues/3599)
 - We moved the dropdown menu for selecting the push-application from the toolbar into the external application preferences. [#674](https://github.com/JabRef/jabref/issues/674)
+- We removed the alphabetical ordering of the custom tabs and updated the error message when trying to create a general field with a name containing an illegal character. [#5019](https://github.com/JabRef/jabref/issues/5019)
 
 
 ### Fixed

src/main/java/org/jabref/gui/customizefields/CustomizeGeneralFieldsDialogViewModel.java

@@ -60,7 +60,7 @@ public void saveFields() {
                 String title = Localization.lang("Error");
                 String content = Localization.lang("Field names are not allowed to contain white space or the following "
                                                    + "characters")
-                                 + ": # { } ~ , ^ &";
+                                 + ": # { } ( ) ~ , ^ & - \" ' ` ʹ \\";
                 dialogService.showInformationDialogAndWait(title, content);
                 return;
             }

src/main/java/org/jabref/gui/entryeditor/EntryEditorTabList.java

@@ -1,9 +1,9 @@
 package org.jabref.gui.entryeditor;
 
 import java.util.Arrays;
+import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.TreeMap;
 
 import org.jabref.preferences.JabRefPreferences;
 
@@ -17,7 +17,7 @@ private EntryEditorTabList() {
     }
 
     public static Map<String, List<String>> create(JabRefPreferences preferences) {
-        Map<String, List<String>> tabs = new TreeMap<>();
+        Map<String, List<String>> tabs = new LinkedHashMap<>();
         int i = 0;
         String name;
         if (preferences.hasKey(JabRefPreferences.CUSTOM_TAB_NAME + 0)) {