Merge pull request #5613 from JabRef/remove-chimbori-isbn-fetcher

Remove Manas Tungare's isbn-to-bibtex fetcher in the queue

Author: Siedlerchr

CHANGELOG.md

@@ -66,7 +66,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
 ### Removed
 
 - We removed some obsolete notifications. [#5555](https://github.com/JabRef/jabref/issues/5555)
-
+- We removed an internal step in the [ISBN-to-BibTeX fetcher](https://docs.jabref.org/import-using-publication-identifiers/isbntobibtex): The [ISBN to BibTeX Converter](https://manas.tungare.name/software/isbn-to-bibtex) by [@manastungare](https://github.com/manastungare) is not used anymore, because it is offline: "people using this tool have not been generating enough sales for Amazon."
 
 
 

src/main/java/org/jabref/logic/importer/fetcher/IsbnFetcher.java

@@ -47,17 +47,10 @@ public Optional<BibEntry> performSearchById(String identifier) throws FetcherExc
 
         IsbnViaEbookDeFetcher isbnViaEbookDeFetcher = new IsbnViaEbookDeFetcher(importFormatPreferences);
         Optional<BibEntry> bibEntry = isbnViaEbookDeFetcher.performSearchById(identifier);
-        
-        // nothing found at ebook.de, try chimbori.com
-        if (!bibEntry.isPresent()) {
-            LOGGER.debug("No entry found at ebook.de try chimbori.com");
-            IsbnViaChimboriFetcher isbnViaChimboriFetcher = new IsbnViaChimboriFetcher(importFormatPreferences);
-            bibEntry = isbnViaChimboriFetcher.performSearchById(identifier);
-        }
 
-        //nothing found at ebook.de and chimbori.com, try ottobib
+        // nothing found at ebook.de: try ottobib
         if (!bibEntry.isPresent()) {
-            LOGGER.debug("No entry found at ebook.de and chimbori.com try ottobib");
+            LOGGER.debug("No entry found at ebook.de; trying ottobib");
             IsbnViaOttoBibFetcher isbnViaOttoBibFetcher = new IsbnViaOttoBibFetcher(importFormatPreferences);
             bibEntry = isbnViaOttoBibFetcher.performSearchById(identifier);
         }

src/main/java/org/jabref/logic/importer/fetcher/IsbnViaChimboriFetcher.java

@@ -5,7 +5,6 @@
 import java.util.stream.Collectors;
 
 import org.jabref.logic.importer.fetcher.AbstractIsbnFetcher;
-import org.jabref.logic.importer.fetcher.IsbnViaChimboriFetcher;
 import org.jabref.logic.importer.fetcher.IsbnViaEbookDeFetcher;
 import org.jabref.logic.importer.fetcher.IsbnViaOttoBibFetcher;
 import org.jabref.logic.importer.fetcher.MrDLibFetcher;
@@ -41,7 +40,6 @@ void getIdBasedFetchersReturnsAllFetcherDerivingFromIdBasedFetcher() throws Exce
             expected.remove(AbstractIsbnFetcher.class);
             expected.remove(IdBasedParserFetcher.class);
             // Remove special ISBN fetcher since we don't want to expose them to the user
-            expected.remove(IsbnViaChimboriFetcher.class);
             expected.remove(IsbnViaEbookDeFetcher.class);
             expected.remove(IsbnViaOttoBibFetcher.class);
             assertEquals(expected, getClasses(idFetchers));

src/test/java/org/jabref/logic/importer/WebFetchersTest.java

@@ -97,10 +97,10 @@ void searchByEntryWithISBNSuccessful() throws FetcherException {
 
     /**
      * This test searches for a valid ISBN. See https://www.amazon.de/dp/3728128155/?tag=jabref-21 However, this ISBN is
-     * not available on ebook.de. The fetcher should something as it falls back to Chimbori
+     * not available on ebook.de. The fetcher should something as it falls back to OttoBib
      */
     @Test
-    void searchForIsbnAvailableAtChimboriButNonOnEbookDe() throws FetcherException {
+    void searchForIsbnAvailableAtOttoBibButNonOnEbookDe() throws FetcherException {
         Optional<BibEntry> fetchedEntry = fetcher.performSearchById("3728128155");
         assertNotEquals(Optional.empty(), fetchedEntry);
     }

src/test/java/org/jabref/logic/importer/fetcher/IsbnFetcherTest.java

@@ -65,7 +65,7 @@ public void searchByIdSuccessfulWithLongISBN() throws FetcherException {
     @Test
     @Override
     public void authorsAreCorrectlyFormatted() throws Exception {
-        BibEntry bibEntry = new BibEntry();
+        bibEntry = new BibEntry();
         bibEntry.setType(StandardEntryType.Book);
         bibEntry.setCiteKey("dumas2018fundamentals");
         bibEntry.setField(StandardField.TITLE, "Fundamentals of business process management");