Merge pull request #6643 from alex-petrov-vt/fix-for-6604

Fixed error when specifying general fields by correcting unwanted characters list

Author: Siedlerchr

CHANGELOG.md

@@ -11,6 +11,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
 
 ### Added
 
+- We improved responsiveness of general fields specification dialog window. [#6643](https://github.com/JabRef/jabref/issues/6604)
 - We added support for importing ris file and load DOI [#6530](https://github.com/JabRef/jabref/issues/6530)
 - We added the Library properties to a context menu on the library tabs [#6485](https://github.com/JabRef/jabref/issues/6485)
 - We added a new field in the preferences in 'BibTeX key generator' for unwanted characters that can be user-specified. [#6295](https://github.com/JabRef/jabref/issues/6295)

src/main/java/org/jabref/gui/customizefields/CustomizeGeneralFieldsDialogViewModel.java

@@ -58,8 +58,12 @@ public void saveFields() {
                 return;
             }
 
-            String testString = CitationKeyGenerator.cleanKey(parts[1], preferences.getUnwantedCharacters());
-            if (!testString.equals(parts[1]) || (parts[1].indexOf('&') >= 0)) {
+            // Use literal string of unwanted characters specified below as opposed to exporting characters
+            // from preferences because the list of allowable characters in this particular differs
+            // i.e. ';' character is allowed in this window, but it's on the list of unwanted chars in preferences
+            String unwantedChars = "#{}()~,^&-\"'`ʹ\\";
+            String testString = CitationKeyGenerator.cleanKey(parts[1], unwantedChars);
+            if (!testString.equals(parts[1])) {
                 dialogService.showInformationDialogAndWait(
                         Localization.lang("Error"),
                         Localization.lang("Field names are not allowed to contain white spaces or certain characters (%0).",