Jabref dialog doesnt respect font size 13558 (#13667)

* Made the AboutDialog's View's Fonts Size's Relative

- note 18 :: 30 == 1.44 :: 2.4 == 0.6
- manually verified original and modified pixel heights

* AboutDialogView responds to preference's font size changes

* Renamed some unused vars to remove IDEA warnings.

* Added information about our fix.

* Removed offending trailing space.

See https://github.com/JabRef/jabref/actions/runs/16790829755/job/47551968304

* AboutAction does not do its own injection now.

  See #13667 (comment)

Author: chrisdenman

CHANGELOG.md

@@ -69,7 +69,8 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We introduced walkthrough functionality [#12664](https://github.com/JabRef/jabref/issues/12664)
 
 ### Fixed
-
+  
+- We fixed an issue whereby the 'About' dialog was not honouring the user's configured font preferences. [#13558](https://github.com/JabRef/jabref/issues/13558)
 - We fixed an issue where the Pagetotal column was sorting the values alphabetically instead of numerically. [#12533](https://github.com/JabRef/jabref/issues/12533)
 - We fixed dark mode of BibTeX Source dialog in Citation Relations tab. [#13599](https://github.com/JabRef/jabref/issues/13599)
 - We fixed an issue where the LibreOffice integration did not support citation keys containing Unicode characters. [#13301](https://github.com/JabRef/jabref/issues/13301)

jabgui/src/main/java/org/jabref/gui/frame/MainMenu.java

@@ -406,7 +406,7 @@ public void execute() {
 
                 new SeparatorMenuItem(),
 
-                factory.createMenuItem(StandardActions.ABOUT, new AboutAction())
+                factory.createMenuItem(StandardActions.ABOUT, new AboutAction(dialogService))
         );
 
         // @formatter:on

jabgui/src/main/java/org/jabref/gui/help/AboutAction.java

@@ -3,23 +3,18 @@
 import org.jabref.gui.DialogService;
 import org.jabref.gui.actions.SimpleCommand;
 
-import com.airhacks.afterburner.injection.Injector;
-
 public class AboutAction extends SimpleCommand {
 
     private final AboutDialogView aboutDialogView;
+    private final DialogService dialogService;
 
-    public AboutAction() {
+    public AboutAction(final DialogService dialogService) {
         this.aboutDialogView = new AboutDialogView();
+        this.dialogService = dialogService;
     }
 
     @Override
     public void execute() {
-        DialogService dialogService = Injector.instantiateModelOrService(DialogService.class);
         dialogService.showCustomDialog(aboutDialogView);
     }
-
-    public AboutDialogView getAboutDialogView() {
-        return aboutDialogView;
-    }
 }

jabgui/src/main/java/org/jabref/gui/help/AboutDialogView.java

@@ -7,6 +7,7 @@
 import org.jabref.gui.ClipBoardManager;
 import org.jabref.gui.DialogService;
 import org.jabref.gui.preferences.GuiPreferences;
+import org.jabref.gui.theme.ThemeManager;
 import org.jabref.gui.util.BaseDialog;
 import org.jabref.gui.util.ControlHelper;
 import org.jabref.logic.l10n.Localization;
@@ -24,6 +25,7 @@ public class AboutDialogView extends BaseDialog<Void> {
     @Inject private GuiPreferences preferences;
     @Inject private ClipBoardManager clipBoardManager;
     @Inject private BuildInfo buildInfo;
+    @Inject private ThemeManager themeManager;
 
     private AboutDialogViewModel viewModel;
 
@@ -34,7 +36,15 @@ public AboutDialogView() {
                   .load()
                   .setAsDialogPane(this);
 
-        ControlHelper.setAction(copyVersionButton, getDialogPane(), event -> copyVersionToClipboard());
+        ControlHelper.setAction(copyVersionButton, getDialogPane(), ignored -> copyVersionToClipboard());
+
+        getDialogPane()
+                .sceneProperty()
+                .addListener((_, ignored, newScene) -> {
+                    if (newScene != null) {
+                        themeManager.updateFontStyle(newScene);
+                    }
+                });
     }
 
     public AboutDialogViewModel getViewModel() {

jabgui/src/main/resources/org/jabref/gui/Base.css

@@ -1853,7 +1853,7 @@ We want to have a look that matches our icons in the tool-bar */
 
 /* AboutDialog */
 #aboutDialog .about-heading {
-    -fx-font-size: 30;
+    -fx-font-size: 2.40em;
     -fx-text-fill: -jr-theme;
 }
 
@@ -1866,12 +1866,12 @@ We want to have a look that matches our icons in the tool-bar */
 }
 
 #aboutDialog .dev-heading {
-    -fx-font-size: 18;
+    -fx-font-size: 1.44em;
     -fx-padding: -10 0 0 0;
 }
 
 #aboutDialog .sub-heading {
-    -fx-font-size: 18;
+    -fx-font-size: 1.44em;
     -fx-padding: 0.312em;
 }