Merge pull request #251 from JabRef/remove-legacy-sync-pdf-or-ps

Removes legacy options to sync files in the "pdf" or "ps" field

Author: simonharrer

CHANGELOG

@@ -1,5 +1,6 @@
 [master]
     - Fixes bug when having added and then removed a personal journal list, an exception is always shown on startup
+    - Removes legacy options to sync files in the "pdf" or "ps" field
     - Removes button to merge entries and keep the old ones.
     - Removes non-compact rank symbols in favor of compact rank
     - All duplicate whitespaces / tabs / newlines are now removed from non-multiline fields

src/main/java/net/sf/jabref/external/AutoSetExternalFileForEntries.java

@@ -1352,8 +1352,6 @@ public void action() {
         actions.put(Actions.ABBREVIATE_ISO, new AbbreviateAction(this, true));
         actions.put(Actions.ABBREVIATE_MEDLINE, new AbbreviateAction(this, false));
         actions.put(Actions.UNABBREVIATE, new UnabbreviateAction(this));
-        actions.put(Actions.AUTO_SET_PDF, new AutoSetExternalFileForEntries(this, "pdf"));
-        actions.put(Actions.AUTO_SET_PS, new AutoSetExternalFileForEntries(this, "ps"));
         actions.put(Actions.AUTO_SET_FILE, new SynchronizeFileField(this));
 
         actions.put(Actions.BACK, (BaseAction) BasePanel.this::back);

src/main/java/net/sf/jabref/gui/BasePanel.java

@@ -364,12 +364,6 @@ public void actionPerformed(ActionEvent e) {
     private final AbstractAction customFileTypesAction = ExternalFileTypeEditor.getAction(this);
     AbstractAction exportToClipboard = new GeneralAction("exportToClipboard",
             Localization.menuTitle("Export selected entries to clipboard"));
-    private final AbstractAction autoSetPdf = new GeneralAction(Actions.AUTO_SET_PDF,
-            Localization.menuTitle("Synchronize PDF links"),
-            prefs.getKey(KeyBinds.SYNCHRONIZE_PDF));
-    private final AbstractAction autoSetPs = new GeneralAction(Actions.AUTO_SET_PS,
-            Localization.menuTitle("Synchronize PS links"),
-            prefs.getKey(KeyBinds.SYNCHRONIZE_PS));
     private final AbstractAction autoSetFile = new GeneralAction(Actions.AUTO_SET_FILE,
             Localization.lang("Synchronize file links"),
             Globals.prefs.getKey(KeyBinds.SYNCHRONIZE_FILES));
@@ -1320,8 +1314,6 @@ private void fillMenu() {
         tools.add(abbreviateMedline);
         tools.add(unabbreviate);
         tools.addSeparator();
-        checkAndFix.add(autoSetPdf);
-        checkAndFix.add(autoSetPs);
         checkAndFix.add(integrityCheckAction);
         tools.add(checkAndFix);
 
@@ -1535,7 +1527,7 @@ private void initActions() {
                  * openInspire */
                 openPdf, openUrl, openFolder, openFile, openSpires, /*openInspire,*/togglePreview, dupliCheck, /*strictDupliCheck,*/highlightAll,
                 highlightAny, newEntryAction, plainTextImport, massSetField, manageKeywords,
-                closeDatabaseAction, switchPreview, integrityCheckAction, autoSetPdf, autoSetPs,
+                closeDatabaseAction, switchPreview, integrityCheckAction,
                 toggleHighlightAny, toggleHighlightAll, databaseProperties, abbreviateIso,
                 abbreviateMedline, unabbreviate, exportAll, exportSelected,
                 importCurrent, saveAll, dbConnect, dbExport, focusTable));