Quirks with groups panel scrolling when adding groups as subgroups or adding items to groups

[AEgit]

JabRef version

JabRef 5.10--2023-04-05--643319b
Windows 10 10.0 amd64
Java 19.0.2
JavaFX 20+19

Operating system

Windows

Details on version and operating system

Windows 10

Checked with the latest development build

• I made a backup of my libraries before testing the latest development version.
• I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

Initial comment here: #2869 (comment)

There are a few quirks, which may or may not be related to the fix for scrolling in the groups panel when adding groups as subgroups (#9728):

1. Open a JabRef database with a large number of static groups and items (thousands of groups and items)
2. Add a group to another group as subgroup using drag'n'drop with the newly implemented scrolling feature. To see the scrolling feature in action, you need to add the group to another group that is not already visible in the groups panel (i.e. the group needs to be further distant from the other group in the groups panel).
3. Note, that the scrolling speed is really high.
   On one hand this is a nice feature for large databases with thousands of groups when you want the child group to be added to a parent group that is very distant in the group table view. On the other hand, it makes it nearly impossible to precisely add a child group to a parent group, since it is very likely that you will whoosh past the parent group due to the scrolling speed. It would be nice if the user could control the scrolling speed by moving the mouse more or less into the direction he wants to put the child group.

Another issue that may or may not be related can be triggered as follows:

1. Open a JabRef database with a large number of static groups and items (thousands of groups and items)
2. Add an item to a group using drag'n'drop with the newly implemented scrolling feature. To see the scrolling feature in action, you need to add the item to a group that is not already visible in the groups panel (i.e. the items current position in the groups panel needs to be further distant from the other group in the groups panel).
3. If you add an article to a group that is far distant (using the new scrolling groups feature) the group table view gets `confused' sometimes and either scrolls to the bottom of the groups panel (after the article has been added) or starts scrolling from top to bottom non-stop. Sometimes it appears to be necessary to have a search term (e.g. a bibtex key) in the search form to trigger this behaviour (at least, that is what it appears to me).

[felipecrp]

It is also happening when you drag a paper to a group.

[felipecrp]

A workaround is to rollback and use version 5.9.

[felipecrp]

I attached a screenshot of the problem.

[tobiasdiez]

Increasing the priority of this bug, since it renders the group tree almost unusable. I think the problem is the following event handler:

jabref/src/main/java/org/jabref/gui/groups/GroupTreeView.java

Lines 461 to 468 in a97d8a9

	groupTree.setOnDragExited(event -> {
	if (event.getY() > 0) {
	scrollVelocity = 1.0 / SCROLL_SPEED;
	} else {
	scrollVelocity = -1.0 / SCROLL_SPEED;
	}
	scrollTimer.restart();
	});

For example, if you leave the treeview sidewards, then it still scrolls down.

Instead of listening to the "onDragExcited" event, I might be better to add two boundary nodes on the top and bottom of the treeview. If the user drags something over them, then it starts scrolling up or down. Can also be used to show a small indicator (if there is a drag & drop in progress).

[calixtus]

Fixed version should be available here: https://builds.jabref.org/pull/10488/merge
Please try and report if this fixes the issue.