Skip to content

Conversation

@northword
Copy link

@northword northword commented Aug 19, 2023

Change delimiter of csv from ; to ,

Fixes JabRef/abbrv.jabref.org#130
Refs JabRef/abbrv.jabref.org#139

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

Please have a look at the failing tests, its seems there are still some test files that need to be converted

@northword
Copy link
Author

@Siedlerchr done, please review again, thanks!

@calixtus
Copy link
Member

Codewise looks good, probably missing a changelog entry yet. Please add a short one.

@northword
Copy link
Author

@calixtus A short description of the change has been added to CHANGELOG.md under the subsection "Change", and pr has been rebased to the latest main branch.

@Siedlerchr Siedlerchr added this to the 5.11 milestone Aug 20, 2023
@Siedlerchr
Copy link
Member

I would propose we wait with merge this one after the release of 5.10 as this includes potential breaking changes. Users who have their own custom journal abbrevs would need to convert their files as well

@Siedlerchr
Copy link
Member

Superseeded by #10281

@Siedlerchr Siedlerchr closed this Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix lists - Migrate from semicolon to comma as separator

3 participants