Skip to content

Conversation

@tobiasdiez
Copy link
Member

Find arXiv ids for multiple entries using Quality -> Lookup identifier -> ArXiv (similar to the same solution for DOI).

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 4, 2017
@Siedlerchr
Copy link
Member

LGTM, but you still have the failing StringUtil test. Seems like you are not on the latest master?

@tobiasdiez
Copy link
Member Author

Yes, the branch was still on yesterdays level.

@tobiasdiez tobiasdiez merged commit b714206 into master Apr 4, 2017
@tobiasdiez tobiasdiez deleted the arxivBatch branch April 4, 2017 20:21
Siedlerchr added a commit that referenced this pull request Apr 5, 2017
* upstream/master:
  fix ID consideration in DuplicateCheck
  Add ArXiv identifier batch lookup (#2710)
  Update mockito from 2.7.19 to 2.7.21
  More defensive identifier list #2708
  Revert "Add more identifier field names #2708"
  Add more identifier field names #2708
  Consider entries as equal if their DOI matches #2708
  Imports
  Imports
  Move duplicate detection to logic
  Reuse edit distance class
  Refactoring
  EntryTypeDialog Fetching Autogenerates BibTeX Key (#2709)
  Add changelog entry
  Increase permitted size of StringUtil
  Make sure that JavaFx shuts down in case another JabRef instance is already open
Siedlerchr added a commit that referenced this pull request Apr 6, 2017
* upstream/master: (35 commits)
  Update antlr from 4.6 to 4.7
  Fix build
  fix ID consideration in DuplicateCheck
  Add ArXiv identifier batch lookup (#2710)
  Update mockito from 2.7.19 to 2.7.21
  More defensive identifier list #2708
  Revert "Add more identifier field names #2708"
  Add more identifier field names #2708
  Consider entries as equal if their DOI matches #2708
  Imports
  Imports
  Move duplicate detection to logic
  Reuse edit distance class
  Refactoring
  EntryTypeDialog Fetching Autogenerates BibTeX Key (#2709)
  Add changelog entry
  Increase permitted size of StringUtil
  Make sure that JavaFx shuts down in case another JabRef instance is already open
  Remove obsolete localization strings
  Hide context menu before group edit/add (probably a JavaFX vs Swing problem)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/groups/GroupTreeController.java
#	src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants