Keep unkwown meta data #2716
Merged
Keep unkwown meta data #2716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenhard
added
the
status: ready-for-review
tobiasdiez
approved these changes
Apr 6, 2017
# Conflicts: # CHANGELOG.md # src/main/java/org/jabref/logic/importer/util/MetaDataParser.java
LinusDietz
approved these changes
Apr 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2704, unkown meta data items were deleted so far. With this PR, this is no longer the case. The only problem is that the formatting of meta data items is not parsed (and this would be a bigger thing), since so far we assumed full control over the meta data items. This version tries to keep formatting as far as possible, but does a few customizations (escaping
;and adding newlines where appropriate). The result is that you can rename agroupstreemeta data item and it will be kept and formatted in the very same way, also with a different name.I would say this is good enough and we adapt it when someone has a use case or problem.