Allow failures for fetcher test #2730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-kolb
added
the
status: ready-for-review
Member
|
I like it. Better than a cronjob-approach bullying us each Monday. We can add a TOP for "Topics discussed in each telephone conference" to discuss the status regularly. |
koppor
approved these changes
Apr 12, 2017
lenhard
approved these changes
Apr 12, 2017
Member
lenhard
left a comment
lenhard
left a comment
There was a problem hiding this comment.
Words cannot express how much I like this PR! This is the single best PR we have implemented since the release of 3.8.2. Oh, how much the fetcher failures were annoying me. Thanks for getting rid of this!
Since @koppor has already given his approval, I'll merge this directly.
Member
Author
|
🤣 |
Siedlerchr
added a commit
that referenced
this pull request
Apr 13, 2017
* upstream/master: (39 commits) Fix fetcher test Allow failures for fetcher test (#2730) Use JabRefExecutor service Move DOI fetching to separate thread #2682 Remove gui dependency in logic (#2726) Fixed freeze on Mac OS X when creating/editing groups (#2727) Only ask once if telemetry data should be collected Update wiremock from 2.5.1 to 2.6.0 Update mockito-core from 2.7.21 to 2.7.22 Update log4j to latest version Azure test (#2724) Fix build Move expand filename to FileUtil Unicode conversion bibtexkey (#2720) Add sorting of all groups and subgroups, recursively (#2666) Only check capitalization of note and howpublished fields if they start with a word character Remove overhauled @author tag Implement #1359: collect telemetry (#2283) Add licenses of new dependencies Fix cssStyleHelper warnings ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As many of @JabRef/developers are annoyed by randomly failing fetcher tests, here's an option to test them but ignore them for the overall build output.
Waiting for your comments if we should do it this way for now.