Fixes #2789 Add Referer to API call #2794
Conversation
stefan-kolb
added
the
status: ready-for-review
|
Could you please add a test? The IEEE-Tests we already have do not cover this fulltext finder |
|
@Siedlerchr Unfortunately it has a lot of GUI and Preferences interdependencies. As it seems we do not have tests for any of those query fetchers yet?! |
|
Of course we have some test for those fetchers - but only for those which have been rewritten to the new structure, e.g., https://github.com/JabRef/jabref/blob/master/src/test/java/org/jabref/logic/importer/fetcher/DBLPFetcherTest.java which tests https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/logic/importer/fetcher/DBLPFetcher.java |
|
Yes, I was talking about the old ones! |
|
Is there an Issue for rewriting those; tagged with "beginner"? 😇
Am 26.04.2017 12:14 schrieb "Stefan Kolb" <[email protected]>:
Yes, I was talking about the old ones!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2794 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABTaftFGcQGu7JpKoGIuuXBs8NjIzm7sks5rzxkYgaJpZM4NHfef>
.
|
|
Tried to add a test, but got stuck with so many dependencies and calls on different Preferences classes :( |
* upstream/master: (84 commits) Update README.md Update CHANGELOG.md Fixes #2789 Add Referer to API call (#2794) Change some FileDialogs to DialogService (#2767) Fix for issue 2762: Change CSV export to separate all names using semicolon (#2793) Set eclipse line wrapping to maximum Do not log an exception if side pane was not found (#2791) Added 'Ink' to the supported FileAnnotationType (required to close #2777) Renamed parseFileAnnotationType() to parse() Reimplement date editor in JavaFX (#2781) Update CONTRIBUTING.md Add new author Fixes handling of unknown PDAnnotation types. Update Checkstyle Version fix some more checkstyle warnings fix some more checkstyle warnings Fix Build failure, hopefully Spanish translation (#2773) Fixes #2766 If file is not found annotations might be null Fix language tests ... # Conflicts: # src/main/java/org/jabref/logic/util/io/FileUtil.java
See #2789.
Please check if this works for you.