Skip to content

Fix ads fetcher #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2017
Merged

Fix ads fetcher #3048

merged 2 commits into from
Jul 25, 2017

Conversation

@Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Jul 25, 2017 •
edited
Loading

Fix for #3035

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 25, 2017
@stefan-kolb
Copy link
Member

stefan-kolb commented Jul 25, 2017

Can we add a small test for this?

@Siedlerchr
Copy link
Member Author

Siedlerchr commented Jul 25, 2017 •
edited
Loading

There are already tests present which failed before and now succeed

@stefan-kolb
Copy link
Member

stefan-kolb commented Jul 25, 2017

Ah right 👍

@Siedlerchr Siedlerchr merged commit 7b74099 into master Jul 25, 2017
@Siedlerchr Siedlerchr deleted the fixads branch July 25, 2017 11:49
Siedlerchr added a commit that referenced this pull request Jul 31, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into selectFilesDlg
b6d43dc 
* upstream/master: (41 commits)
  update xmlunit from 2.3.0 -> 2.4.0
  update wiremock from 2.6.0 -> 2.7.0
  update controlsfx from 8.40.12 -> 8.40.13
  Fix group freeze by running markBasechange in swing thread (#3058)
  Localization: French: translation of new entries (#3050)
  Fix ads fetcher (#3048)
  Update translation (#3041)
  Translate new strings (#3040)
  Fix navigation in entry editor increases modifies font size (#3037)
  Initial idea for architectural decision records (#3033)
  Readd comment
  Readd comment
  Fix keybdining in entry editor in localized installation (#3030)
  Structuring
  Upgrade shadowJar
  Modernizer improvements
  Replace Reimplement MappedList.kt (#3032)
  Use https for the maven ej-technologies repo
  Upgrade modernizer plugin
  Remove separator next to search bar
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefan-kolb stefan-kolb stefan-kolb approved these changes

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Siedlerchr @stefan-kolb @tobiasdiez