Skip to content

Fix enum class cast error in TreeSet by specifying an explicit comparator #5184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2019
Merged

Fix enum class cast error in TreeSet by specifying an explicit comparator #5184

merged 1 commit into from
Aug 13, 2019

Conversation

@Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Aug 10, 2019

because natural order will require same types of the enum

Followup from #5148

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@Siedlerchr
Fix enum class cast in TreeSet error by specifying an explicit compar…
0eabed6 
…ator

because natural order will require same types of the enum

Followup from  #5148
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 10, 2019
@Siedlerchr Siedlerchr changed the title Fix enum class cast in TreeSet error by specifying an explicit comparator Fix enum class cast error in TreeSet by specifying an explicit comparator Aug 10, 2019
davidemdot
davidemdot approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@davidemdot davidemdot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Siedlerchr Siedlerchr merged commit 0255dda into master Aug 13, 2019
@Siedlerchr Siedlerchr deleted the fixEnumErrorClassCAst branch August 13, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@davidemdot davidemdot davidemdot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Siedlerchr @davidemdot