Skip to content

Conversation

@Nik014
Copy link
Contributor

@Nik014 Nik014 commented Jun 20, 2015

No description provided.

@koppor
Copy link
Member

koppor commented Jun 21, 2015

What do you mean by "prevent ant builds"? Even with the patch, ant jars outputs Compile failed; see the compiler error output for details., because the compiler cannot find certain packages.

gradlew antTargets.release runs through even without the patch.

Apache Ant(TM) version 1.9.5 compiled on May 31 2015. Which version do you have, what is your output?

@Nik014
Copy link
Contributor Author

Nik014 commented Jun 21, 2015

I'm building on Linux. Without the patch, both ./gradlew antTargets.jars and ./gradlew antTargets.release.linux fail, because the compiler can't find the dependencies. On the other hand, ./gradlew generateSource and ./gradlew jar run fine.

After some digging around, I found that paths in configurations.compile.asPath are separated by : instead of ; -- at least on Linux, don't know if that's the case on other platforms.

I haven't tried ant jars and I doubt it would work, because the paths to dependencies are now passed through gradle.

@koppor koppor merged commit 990e2ab into JabRef:master Jun 21, 2015
@koppor
Copy link
Member

koppor commented Jun 21, 2015

It is different on Linux and Windows. I wrapped the thing in an if statement :). Thank you for testing and providing a PR.

@Nik014
Copy link
Contributor Author

Nik014 commented Jun 21, 2015

Sure, no problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants