Skip to content

Make the DOI Resolution Fetcher return nothing when the DOI leads to a host for which a tailored fetcher exists #6937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Make the DOI Resolution Fetcher return nothing when the DOI leads to a host for which a tailored fetcher exists #6937

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eae8a8a
Make the DOI Resolution Fetcher return nothing when the DOI leads to …
Toromtomtom Sep 23, 2020
8c13808
fixes a Checkstyle error
Toromtomtom Sep 24, 2020
99f76d2
revert the last two commits
Toromtomtom Sep 25, 2020
6783268
decrease the trust level of the DOI resolution fetcher
Toromtomtom Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/logic/importer/fetcher/DoiResolution.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,6 @@ private Optional<URL> findSimilarLinks(List<URL> urls) {

@Override
public TrustLevel getTrustLevel() {
return TrustLevel.SOURCE;
return TrustLevel.META_SEARCH;
Copy link
Member

@koppor koppor Sep 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This decreases the result quality of the DOI fetcher (always leading to the "right" paper) to the quality of Google Scholar. (From the highest to the lowest)

Can the solution of the title? 😇

Make the DOI Resolution Fetcher return nothing when the DOI leads to a host for which a tailored fetcher exists

}
}