Skip to content

Disable certain fetcher tests on CI #7348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2021
Merged

Disable certain fetcher tests on CI #7348

merged 2 commits into from
Jan 14, 2021

Conversation

@koppor
Copy link
Member

@koppor koppor commented Jan 14, 2021 •
edited
Loading

Disable GoogleScholar and JSTOR. (Refs #7229)

Other fetchers will be fixed later.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@koppor
Copy link
Member Author

koppor commented Jan 14, 2021

Since we already approved #7229, I will merge.

@koppor koppor marked this pull request as ready for review January 14, 2021 21:57
@koppor koppor merged commit edc6fa3 into master Jan 14, 2021
@koppor koppor deleted the disable-google-scholar-and-jstor-fetcher-tests branch January 14, 2021 22:53
Siedlerchr added a commit that referenced this pull request Jan 15, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into importerbackgroun…
e21a060 
…dtask

* upstream/master:
  Fix regex (#7352)
  Disable certain fetcher tests on CI (#7348)
  Add date fields (#7334)

# Conflicts:
#	src/main/java/org/jabref/logic/externalfiles/ExternalFilesContentImporter.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixtus calixtus calixtus approved these changes

+1 more reviewer

@DominikVoigt DominikVoigt DominikVoigt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component: fetcher

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@koppor @DominikVoigt @calixtus