Fix bug with ipv6 conversion in ipToBuffer (#101)

JoshGlazebrook · web-flow · commit 992b0023d2f1 · 2024-04-09T12:43:44.000-05:00
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "socks",
   "private": false,
-  "version": "2.8.1",
+  "version": "2.8.2",
   "description": "Fully featured SOCKS proxy client supporting SOCKSv4, SOCKSv4a, and SOCKSv5. Includes Bind and Associate functionality.",
   "main": "build/index.js",
   "typings": "typings/index.d.ts",
diff --git a/src/common/helpers.ts b/src/common/helpers.ts
@@ -236,8 +236,9 @@ export function ipToBuffer(ip: string): Buffer {
   } else if (net.isIPv6(ip)) {
     // Handle IPv6 addresses
     const address = new Address6(ip);
-    return Buffer.from(address.toByteArray());
+    return Buffer.from(address.canonicalForm().split(":").map(segment => segment.padStart(4, '0')).join(''), 'hex');
   } else {
     throw new Error('Invalid IP address format');
   }
 }
+

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "socks",`
`3`	`3`	`"private": false,`
`4`		`- "version": "2.8.1",`
	`4`	`+ "version": "2.8.2",`
`5`	`5`	`"description": "Fully featured SOCKS proxy client supporting SOCKSv4, SOCKSv4a, and SOCKSv5. Includes Bind and Associate functionality.",`
`6`	`6`	`"main": "build/index.js",`
`7`	`7`	`"typings": "typings/index.d.ts",`
Original file line number	Diff line number	Diff line change
`@@ -236,8 +236,9 @@ export function ipToBuffer(ip: string): Buffer {`
`236`	`236`	`} else if (net.isIPv6(ip)) {`
`237`	`237`	`// Handle IPv6 addresses`
`238`	`238`	`const address = new Address6(ip);`
`239`		`- return Buffer.from(address.toByteArray());`
	`239`	`+ return Buffer.from(address.canonicalForm().split(":").map(segment => segment.padStart(4, '0')).join(''), 'hex');`
`240`	`240`	`} else {`
`241`	`241`	`throw new Error('Invalid IP address format');`
`242`	`242`	`}`
`243`	`243`	`}`
	`244`	`+`