Don't use generated in initialized_blocks_BlockArray (#361)

* Don't use generated in initialized_blocks_BlockArray

* Add test

Author: jishnub

src/blockarray.jl

@@ -183,16 +183,12 @@ See also [`undef_blocks`](@ref), [`UndefBlocksInitializer`](@ref)
 @inline BlockArray{T,N,R}(::UndefBlocksInitializer, block_sizes::Vararg{AbstractVector{<:Integer}, N}) where {T, N, R<:AbstractArray{<:AbstractArray{T,N},N}} =
     undef_blocks_BlockArray(R, block_sizes...)
 
-@generated function initialized_blocks_BlockArray(::Type{R}, baxes::NTuple{N,AbstractUnitRange{Int}}) where R<:AbstractArray{V,N} where {T,N,V<:AbstractArray{T,N}}
-    return quote
-        block_arr = _BlockArray(R, baxes)
-        @nloops $N i i->blockaxes(baxes[i],1) begin
-            block_index = @ntuple $N i
-            block_arr[block_index...] = similar(V, length.(getindex.(baxes, block_index)))
-        end
-
-        return block_arr
+function initialized_blocks_BlockArray(::Type{R}, baxes::NTuple{N,AbstractUnitRange{Int}}) where R<:AbstractArray{V,N} where {T,N,V<:AbstractArray{T,N}}
+    blocks = map(Iterators.product(map(x -> blockaxes(x,1), baxes)...)) do block_index
+        indices = map((x,y) -> x[y], baxes, block_index)
+        similar(V, map(length, indices))
     end
+    return _BlockArray(convert(R, blocks), baxes)
 end
 
 

test/test_blockarrays.jl

@@ -1,4 +1,4 @@
-using SparseArrays, BlockArrays, FillArrays, LinearAlgebra, Test
+using SparseArrays, BlockArrays, FillArrays, LinearAlgebra, Test, OffsetArrays
 import BlockArrays: _BlockArray
 
 function test_error_message(f, needle, expected = Exception)
@@ -27,6 +27,19 @@ end
             fill!(ret, 0)
             @test Array(ret)  == zeros(6)
 
+            ret = BlockArray{Float64,1,Vector{OffsetVector{Float64,Vector{Float64}}}}(undef, 1:3)
+            fill!(ret, 0)
+            @test blocks(ret) isa Vector{OffsetVector{Float64,Vector{Float64}}}
+            @test Array(ret)  == zeros(6)
+
+            ret = BlockArray{Float64,1,
+                        OffsetVector{OffsetVector{Float64,Vector{Float64}},
+                            Vector{OffsetVector{Float64,Vector{Float64}}}}}(undef, 1:3)
+            fill!(ret, 0)
+            @test blocks(ret) isa OffsetVector{OffsetVector{Float64,Vector{Float64}},
+                                    Vector{OffsetVector{Float64,Vector{Float64}}}}
+            @test Array(ret)  == zeros(6)
+
             ret = BlockArray{Float64}(undef, (blockedrange(1:3),))
             fill!(ret, 0)
             @test Array(ret)  == zeros(6)