Skip to content

Commit 8c1eea0

Browse files
nalimilanararslan
authored andcommitted
Fix using Vector{Bool} instead of BitVector in find benchmarks (#182)
The benchmarks did not actually test Vector{Bool} for the 80/20 and 20/80 cases since .> and .< return BitVectors.
1 parent 2804787 commit 8c1eea0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/find/FindBenchmarks.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ g = addgroup!(SUITE, "findall")
1616

1717
const VEC_LENGTH = 1000
1818

19-
for (name, x) in (("50-50", samerand(Bool, VEC_LENGTH)),
20-
("10-90", samerand(VEC_LENGTH) .> .9),
21-
("90-10", samerand(VEC_LENGTH) .> .1))
19+
for (name, x) in (("50-50", Vector{Bool}(samerand(Bool, VEC_LENGTH))),
20+
("10-90", Vector{Bool}(samerand(VEC_LENGTH) .> .9)),
21+
("90-10", Vector{Bool}(samerand(VEC_LENGTH) .> .1)))
2222
bx = BitArray(x)
2323
gx = (v for v in x)
2424

0 commit comments

Comments
 (0)