fix more replacename changes required #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed in f111efe, caught in trying to test JuliaLang/julia#58279.
This reverts commit 5736a50. There doesn't seem to be any explanation for this change, and it breaks on old versions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #137 +/- ##
===========================================
- Coverage 88.69% 76.95% -11.75%
===========================================
Files 6 6
Lines 1442 1523 +81
===========================================
- Hits 1279 1172 -107
- Misses 163 351 +188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…jl into vtjnash-jn/replaceglob
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed in f111efe, caught in trying to test JuliaLang/julia#58279.