fix Distances compat (#423)

* CompatHelper: bump compat for Distances to 0.10 for package test, (keep existing compat)

* try out Theo's fix

* fix test compat

* use ForwardDiff for chain rule test of SqMahalanobis

* test on 1.4 instead of 1.3 - see if the chainrules test passes there

* revert version branch

* revert to 1.3

* test_broken for older Julia versions

Co-authored-by: CompatHelper Julia <[email protected]>

Author: st--

src/chainrules.jl

@@ -118,7 +118,7 @@ function ChainRulesCore.rrule(s::Sinus, x::AbstractVector, y::AbstractVector)
     return val, evaluate_pullback
 end
 
-## Reverse Rulse SqMahalanobis
+## Reverse Rules SqMahalanobis
 
 function ChainRulesCore.rrule(
     dist::Distances.SqMahalanobis, a::AbstractVector, b::AbstractVector

test/Project.toml

@@ -19,7 +19,7 @@ Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
 [compat]
 AxisArrays = "0.4.3"
 Compat = "3"
-Distances = "= 0.10.0, = 0.10.1, = 0.10.2, = 0.10.3, = 0.10.4"
+Distances = "0.10"
 Documenter = "0.25, 0.26, 0.27"
 FiniteDifferences = "0.10.8, 0.11, 0.12"
 ForwardDiff = "0.10"

test/chainrules.jl

@@ -21,7 +21,11 @@
     compare_gradient(:Zygote, [x, y]) do xy
         KernelFunctions.Sinus(r)(xy[1], xy[2])
     end
-    compare_gradient(:Zygote, [Q, x, y]) do xy
-        SqMahalanobis(xy[1])(xy[2], xy[3])
+    if VERSION < v"1.6"
+        @test_broken "Chain rule of SqMahalanobis is broken in Julia pre-1.6"
+    else
+        compare_gradient(:Zygote, [Q, x, y]) do Qxy
+            SqMahalanobis(Qxy[1])(Qxy[2], Qxy[3])
+        end
     end
 end