Skip to content

Yet another PR for Julia v1 #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 54 commits into from
Closed

Yet another PR for Julia v1 #110

wants to merge 54 commits into from

Conversation

@jaakkor2
Copy link
Contributor

@jaakkor2 jaakkor2 commented Feb 3, 2019 •
edited
Loading

Take master, merge #86, resolve conflicts and remove Compat.

Status 2019-2-18:

  • Travis passes build job 204
  • local testing ]test MAT
    • windows 7 x64 Julia v1.1 passes

halleysfifthinc and others added 30 commits July 30, 2018 16:52
@halleysfifthinc
Resolve deprecation warnings for v0.7
ce68214
@halleysfifthinc
Drop v0.5 and v0.6, add v0.7
4bf5b9b
@halleysfifthinc
Remove precompile statement
497519e
@halleysfifthinc
Make MatlabString const (Only used as a singleton)
412151e
@halleysfifthinc
Update .travis.yml
de295c2
@halleysfifthinc
Fix HDF5 build hang on OSX
439f035
@halleysfifthinc
Didn't work
27fae3d
@halleysfifthinc
Take #2 to fix Travis on OSX
abdcc68
@halleysfifthinc
Update REQUIRE
d974cdc
@halleysfifthinc
Fix Complex reads
1ea692b
@halleysfifthinc
Avoid copying string
ccad554
@halleysfifthinc
Simplify read_complex
3f090ae
@halleysfifthinc
Simplify read(obj, ::Type{Array{Bool}})
835bf4b
@halleysfifthinc
Add two more tests for complex writes
c40d0e0
@halleysfifthinc
Simplify m_writearray
4cf604e
@halleysfifthinc
Simplify silly bit-twiddling in m_write
da1cdaf
@halleysfifthinc
Change potentially costly length call
c60910b
@halleysfifthinc
Preserve magic and identifier during unsafe copy
c9a85b9
@halleysfifthinc
Fix extra copies in read(obj, ::Type{Array{Bool}})
fbbde1b
@halleysfifthinc
Fix extra copies in read_matrix
a1e7ae6
@halleysfifthinc @yuyichao
Resolve deprecation warnings for v0.7
a5a874e
@halleysfifthinc @yuyichao
Drop v0.6
a221115
@halleysfifthinc @yuyichao
Remove precompile statement
a1fc40c
@halleysfifthinc @yuyichao
Make MatlabString const (Only used as a singleton)
c65debe
@halleysfifthinc @yuyichao
Update .travis.yml
e5998ae
@halleysfifthinc @yuyichao
Fix HDF5 build hang on OSX
33f7418
@halleysfifthinc @yuyichao
Didn't work
9d6ce95
@halleysfifthinc @yuyichao
Take #2 to fix Travis on OSX
044bda6
@halleysfifthinc @yuyichao
Fix Complex reads
3471b03
@halleysfifthinc @yuyichao
Avoid copying string
a60bf9c
@jaakkor2 jaakkor2 changed the title Yet another PR for Julia v1 with tests passing Yet another PR for Julia v1 Feb 3, 2019
yuyichao
yuyichao requested changes Feb 5, 2019
View reviewed changes
@alexcanepa
Copy link

alexcanepa commented Feb 16, 2019

@yuyichao bump on this PR, it's pretty frustrating to depend on forks of this package for usability

yuyichao
yuyichao requested changes Feb 17, 2019
View reviewed changes
Copy link
Collaborator

@yuyichao yuyichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the two changes requested should easy to check/test.

Other changes all looks good. (given that test pass).

@jaakkor2 jaakkor2 mentioned this pull request Feb 17, 2019
Closed
@jaakkor2
Copy link
Contributor Author

jaakkor2 commented Feb 17, 2019 •
edited
Loading

Latest change requests from @yuyichao taken into account.
Tests pass on Linux, random fails in osx. Local tests pass on Windows x64 Julia v1.1.
Opened #112 to track the randomly failing travis jobs.

@jaakkor2 jaakkor2 mentioned this pull request Feb 17, 2019
Closed
@jruohio-invn
Create temporary file name using function call tempname() instead o…
e74d0b6 
…f string `tempname`. Could prevent Travis race condition when writing the file.
@jaakkor2 jaakkor2 closed this Feb 18, 2019
@jaakkor2
Copy link
Contributor Author

jaakkor2 commented Feb 18, 2019

Close and reopen in hope to trigger another Travis build job

@jaakkor2 jaakkor2 reopened this Feb 18, 2019
@timholy timholy mentioned this pull request Feb 18, 2019
Merged
@timholy
Copy link
Member

timholy commented Feb 18, 2019

Nice to see this getting over the finish line. I cleaned this up, git history-wise, in #113. We can close this when that merges.

@timholy timholy closed this in #113 Feb 18, 2019
timholy added a commit that referenced this pull request Feb 18, 2019
@timholy
Merge pull request #113 from JuliaIO/merge_julia07
4bb7a91 
Clean up git history of #110
@timholy
Copy link
Member

timholy commented Feb 18, 2019

Thanks for your efforts, @jaakkor2 and @yuyichao!

@timholy timholy mentioned this pull request Feb 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuyichao yuyichao yuyichao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jaakkor2 @alexcanepa @timholy @yuyichao @halleysfifthinc @nicoleepp @jruohio-invn