v0.6 compatibility #173
Merged
v0.6 compatibility #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A dozen more v0.6 fixes
includes a dirty patch to allow the new syntax `RObject{S}(p::Ptr{S}) where S`
it also works for julia 0.5 now
tkelman
reviewed
Mar 25, 2017
| # Compat.jl not yet provide support for the new syntax for inner consturctor | ||
| # https://github.com/JuliaLang/Compat.jl/issues/332 | ||
| # and the new syntax cannot be parse in julie v0.5, therefore using string. | ||
| if VERSION < v"0.6.0-" |
Contributor
There was a problem hiding this comment.
use a more specific cutoff for this. run contrib/commit-name.sh at the merge commit for the type system rewrite pr
Member
There was a problem hiding this comment.
Actually the best solution is to use the call overloading syntax, which works on both 0.5 and 0.6. See JuliaLang/Compat.jl#332.
Member
Author
|
It was fixed on the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made several changes to the 0.6 branch, the code is now compatible with both v0.5 and v0.6.
The REPL mode on v0.6 is still broken, but a patch is submitted to julia.
It will be merged into master once the tests pass.