Skip to content

Commit 110fb2d

Browse files
committed
Drop compat code for partialsort from #401
1 parent a5af839 commit 110fb2d

File tree

4 files changed

+6
-18
lines changed

4 files changed

+6
-18
lines changed

README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -220,9 +220,6 @@ Currently, the `@compat` macro supports the following syntaxes:
220220

221221
* `Range` is now `AbstractRange` ([#23570])
222222

223-
* `select`* functions (`select`, `select!`, `selectperm`, `selectperm!`) are renamed to
224-
`partialsort`* (`partialsort`, `partialsort!`, `partialsortperm`, `partialsortperm!`) ([#23051])
225-
226223
* `IntSet` is now `BitSet` ([#24282])
227224

228225
* `strwidth` and `charwidth` are now merged into `textwidth` ([#23667]).

src/Compat.jl

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,6 @@ import Base.MathConstants
2323

2424
include("compatmacro.jl")
2525

26-
# 0.7.0-DEV.1535
27-
@static if !isdefined(Base, :partialsort)
28-
const partialsort = select
29-
const partialsort! = select!
30-
const partialsortperm = selectperm
31-
const partialsortperm! = selectperm!
32-
export partialsort, partialsort!, partialsortperm, partialsortperm!
33-
end
34-
3526
# 0.7.0-DEV.1660
3627
@static if !isdefined(Base, :pairs)
3728
pairs(collection) = Base.Generator(=>, keys(collection), values(collection))

test/old.jl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,3 +246,9 @@ let M = [1 + 2im 3 + 4im; 5 + 6im 7 + 8im],
246246
adjoint!(M2, M)
247247
@test M2 == Mc
248248
end
249+
250+
# 0.7
251+
@test partialsort([3,6,30,1,9], 2, rev=true) == 9
252+
@test partialsort([3,6,30,1,9], 2, by=x->1/x) == 9
253+
@test partialsortperm([3,6,30,1,9], 2, rev=true) == 5
254+
@test partialsortperm([3,6,30,1,9], 2, by=x->1/x) == 5

test/runtests.jl

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,12 +103,6 @@ end
103103
# 0.7
104104
@test isa(1:2, AbstractRange)
105105

106-
# 0.7
107-
@test partialsort([3,6,30,1,9], 2, rev=true) == 9
108-
@test partialsort([3,6,30,1,9], 2, by=x->1/x) == 9
109-
@test partialsortperm([3,6,30,1,9], 2, rev=true) == 5
110-
@test partialsortperm([3,6,30,1,9], 2, by=x->1/x) == 5
111-
112106
# 0.7
113107
@test isa(Base.rtoldefault(1.0, 2.0, 0), Float64)
114108
@test isa(Base.rtoldefault(Float64, 2.0, 0), Float64)

0 commit comments

Comments
 (0)