Skip to content

Conversation

@fredrikekre
Copy link
Member

No description provided.

@fredrikekre fredrikekre requested a review from ararslan February 23, 2018 10:01
@fredrikekre
Copy link
Member Author

fredrikekre commented Feb 23, 2018

Hmm... This will not work because some functions changes Base.stdout but Compat.stdout will always point to the old one. See e.g. the test failure on 0.6.

@fredrikekre fredrikekre deleted the fe/std branch February 23, 2018 10:50
@stevengj
Copy link
Member

Yes, it needs to be done with @compat to rewrite at the source level, I think.

@yuyichao
Copy link
Contributor

Not necessarily.

julia> module A
       a = 1
       end
Main.A

julia> module B
       import ..A.a
       end
Main.B

julia> B.a
1

julia> A.a
1

julia> A.eval(:(a = 2))
2

julia> B.a
2

julia> A.a
2

@yuyichao
Copy link
Contributor

Actually nvm, I guess this doesn't work for renaming...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants