Move overload of Base.range() to JuliaSyntax.byte_range()

The Base overload was a mistake - it doesn't really have the same
semantics as compared to `Base.range()`. It's also not got the clearest
name!

Author: c42f

src/diagnostics.jl

@@ -40,7 +40,6 @@ end
 first_byte(d::Diagnostic) = d.first_byte
 last_byte(d::Diagnostic)  = d.last_byte
 is_error(d::Diagnostic)   = d.level === :error
-Base.range(d::Diagnostic) = first_byte(d):last_byte(d)
 
 # Make relative path into a file URL
 function _file_url(filename)
@@ -89,7 +88,7 @@ function show_diagnostic(io::IO, diagnostic::Diagnostic, source::SourceFile)
     _printstyled(io, "# $prefix @ ", fgcolor=:light_black)
     _printstyled(io, "$locstr", fgcolor=:light_black, href=file_href)
     print(io, "\n")
-    highlight(io, source, range(diagnostic),
+    highlight(io, source, byte_range(diagnostic),
               note=diagnostic.message, notecolor=color,
               context_lines_before=1, context_lines_after=0)
 end

src/syntax_tree.jl

@@ -123,18 +123,15 @@ span(node::AbstractSyntaxNode) = span(node.raw)
 
 first_byte(node::AbstractSyntaxNode) = node.position
 last_byte(node::AbstractSyntaxNode)  = node.position + span(node) - 1
+byte_range(node) = first_byte(node):last_byte(node)
 
 """
     sourcetext(node)
 
 Get the full source text of a node.
 """
 function sourcetext(node::AbstractSyntaxNode)
-    view(node.source, range(node))
-end
-
-function Base.range(node::AbstractSyntaxNode)
-    (node.position-1) .+ (1:span(node))
+    view(node.source, byte_range(node))
 end
 
 source_line(node::AbstractSyntaxNode) = source_line(node.source, node.position)

tools/check_all_packages.jl

@@ -39,7 +39,7 @@ Logging.with_logger(TerminalLogger()) do
                 mismatch_count += 1
                 failing_source = sprint(context=:color=>true) do io
                     for c in reduce_tree(parseall(SyntaxNode, text))
-                        JuliaSyntax.highlight(io, c.source, range(c), context_lines_inner=5)
+                        JuliaSyntax.highlight(io, c.source, JuliaSyntax.byte_range(c), context_lines_inner=5)
                         println(io, "\n")
                     end
                 end