Skip to content

Conversation

@whatsthecraic
Copy link
Contributor

Similarly to the Julia implementation of Logging.handle_message(::ConsoleLogger, ...), the PR avoids specializing handle_message for the different combinations of arguments.

@kpamnany
Copy link
Member

kpamnany commented Sep 9, 2025

Attn: @vchuravy, @Keno, @KristofferC

Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. Especially since the inner call will simply be another dynamic dispatch, there's absolutely no reason to specialize this. 👍

EDIT: Oh, jk, i don't have merge rights on this repo I guess.

@KristofferC
Copy link
Member

Looks uncontroversial so I'll merge.

@KristofferC KristofferC merged commit c9782ac into JuliaLang:main Sep 10, 2025
15 checks passed
@nickrobinson251 nickrobinson251 mentioned this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants