Skip to content

Commit 2ca4c5b

Browse files
committed
Remove matrix * vector specialization for strided arrays
This method entirely duplicates the one below it with the exception that it also does a `convert` on one of the inputs with the result of `promote_op`, which doesn't make a whole lot of sense in some cases. By virtue of calling `mul!`, strided arrays that go through the abstract array method will still hit the same optimized methods that use BLAS. Fixes #32092.
1 parent 6e04733 commit 2ca4c5b

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

stdlib/LinearAlgebra/src/matmul.jl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,6 @@ function *(transx::Transpose{<:Any,<:StridedVector{T}}, y::StridedVector{T}) whe
4141
end
4242

4343
# Matrix-vector multiplication
44-
function (*)(A::StridedMatrix{T}, x::StridedVector{S}) where {T<:BlasFloat,S}
45-
TS = promote_op(matprod, T, S)
46-
mul!(similar(x, TS, size(A,1)), A, convert(AbstractVector{TS}, x))
47-
end
4844
function (*)(A::AbstractMatrix{T}, x::AbstractVector{S}) where {T,S}
4945
TS = promote_op(matprod, T, S)
5046
mul!(similar(x,TS,axes(A,1)),A,x)

0 commit comments

Comments
 (0)