Change default warn color to yellow (#18453)

* Change default warn color to yellow

* add news entry

* das

* foo

* Update client.jl

* Update NEWS.md

* fix typo

Author: KristofferC

NEWS.md

@@ -60,9 +60,9 @@ Library improvements
     Therefore, light versions of the colors are now supported.
     For the available colors see the help entry on `print_with_color`.
 
-  * The default color for info messages has been changed from blue to cyan ([#18442]).
-    This can be changed back to the original color by setting the environment variable `JULIA_INFO_COLOR` to `"blue"`.
-    One way of doing this is by adding `ENV["JULIA_INFO_COLOR"] = :blue` to the `.juliarc.jl` file.
+  * The default color for info messages has been changed from blue to cyan and for warning messages from red to yellow.
+    This can be changed back to the original colors by setting the environment variables `JULIA_INFO_COLOR` to `"blue"` and `JULIA_WARN_COLOR` to `"red"`.
+    One way of doing this is by adding for example `ENV["JULIA_INFO_COLOR"] = :blue` and `ENV["JULIA_WARN_COLOR"] = :red` to the `.juliarc.jl` file.
     For more information regarding customizing colors in the REPL, see this [manual section]( http://docs.julialang.org/en/latest/manual/interacting-with-julia/#customizing-colors).
 
   * Iteration utilities that wrap iterators and return other iterators (`enumerate`, `zip`, `rest`,

base/client.jl

@@ -56,7 +56,7 @@ will print text with all text properties (like boldness) reset.
 text_colors
 
 have_color = false
-default_color_warn = :light_red
+default_color_warn = :yellow
 default_color_error = :light_red
 default_color_info = :cyan
 if is_windows()

base/pkg/entry.jl

@@ -179,7 +179,7 @@ function status(io::IO, pkg::AbstractString, ver::VersionNumber, fix::Bool)
             finalize(prepo)
         end
     else
-        print_with_color(:yellow, io, "non-repo (unregistered)")
+        print_with_color(Base.warn_color(), io, "non-repo (unregistered)")
     end
     println(io)
 end

base/test.jl

@@ -140,7 +140,7 @@ type Broken <: Result
     orig_expr
 end
 function Base.show(io::IO, t::Broken)
-    print_with_color(:yellow, io, "Test Broken\n"; bold = true)
+    print_with_color(Base.warn_color(), io, "Test Broken\n"; bold = true)
     if t.test_type == :skipped && !(t.orig_expr === nothing)
         println(io, "  Skipped: ", t.orig_expr)
     elseif !(t.orig_expr === nothing)
@@ -489,7 +489,7 @@ function print_test_results(ts::DefaultTestSet, depth_pad=0)
         print_with_color(Base.error_color(), lpad("Error",error_width," "), "  "; bold = true)
     end
     if broken_width > 0
-        print_with_color(:yellow, lpad("Broken",broken_width," "), "  "; bold = true)
+        print_with_color(Base.warn_color(), lpad("Broken",broken_width," "), "  "; bold = true)
     end
     if total_width > 0
         print_with_color(Base.info_color(), lpad("Total",total_width, " "); bold = true)
@@ -619,7 +619,7 @@ function print_counts(ts::DefaultTestSet, depth, align,
 
     nb = broken + c_broken
     if nb > 0
-        print_with_color(:yellow, lpad(string(nb), broken_width, " "), "  ")
+        print_with_color(Base.warn_color(), lpad(string(nb), broken_width, " "), "  ")
     elseif broken_width > 0
         # None broken at this level, but some at another level
         print(lpad(" ", broken_width), "  ")