Skip to content

Commit 41dfcd5

Browse files
timholyvtjnash
andauthored
Apply suggestions from code review
Co-authored-by: Jameson Nash <[email protected]>
1 parent f105b21 commit 41dfcd5

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

stdlib/REPL/src/REPL.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@ LineEditREPL(t::TextTerminal, hascolor::Bool, envcolors::Bool=false) =
429429
)
430430

431431
mutable struct REPLCompletionProvider <: CompletionProvider
432-
modifier::Symbol
432+
shift::Bool
433433
end
434434
REPLCompletionProvider() = REPLCompletionProvider(:none)
435435
mutable struct ShellCompletionProvider <: CompletionProvider end

stdlib/REPL/src/REPLCompletions.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -490,16 +490,16 @@ function complete_any_methods(ex_org::Expr, callee_module::Module, context_modul
490490
end
491491

492492
for name in names(callee_module; all=true)
493-
if isdefined(callee_module, name)
493+
if !isdeprecated(callee_module, name) && isdefined(callee_module, name)
494494
func = getfield(callee_module, name)
495-
if isa(func, Base.Callable) && func !== Vararg
495+
if !isa(func, Module)
496496
complete_methods!(out, func, args_ex, kwargs_ex, moreargs)
497497
elseif callee_module === Main::Module && isa(func, Module)
498498
callee_module2 = func
499499
for name in names(callee_module2)
500500
if isdefined(callee_module2, name)
501501
func = getfield(callee_module, name)
502-
if isa(func, Base.Callable) && func !== Vararg
502+
if isa(func, Base.Callable)
503503
complete_methods!(out, func, args_ex, kwargs_ex, moreargs)
504504
end
505505
end

0 commit comments

Comments
 (0)