Skip to content

Commit 44417bd

Browse files
committed
Make pinv work for Adjoint
Fixes #29723
1 parent 82c4fce commit 44417bd

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

stdlib/LinearAlgebra/src/dense.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1240,7 +1240,7 @@ julia> M * N
12401240
12411241
[^KY88]: Konstantinos Konstantinides and Kung Yao, "Statistical analysis of effective singular values in matrix rank determination", IEEE Transactions on Acoustics, Speech and Signal Processing, 36(5), 1988, 757-763. [doi:10.1109/29.1585](https://doi.org/10.1109/29.1585)
12421242
"""
1243-
function pinv(A::StridedMatrix{T}, rtol::Real) where T
1243+
function pinv(A::AbstractMatrix{T}, rtol::Real) where T
12441244
m, n = size(A)
12451245
Tout = typeof(zero(T)/sqrt(one(T) + one(T)))
12461246
if m == 0 || n == 0
@@ -1269,7 +1269,7 @@ function pinv(A::StridedMatrix{T}, rtol::Real) where T
12691269
Sinv[findall(.!isfinite.(Sinv))] .= zero(Stype)
12701270
return SVD.Vt' * (Diagonal(Sinv) * SVD.U')
12711271
end
1272-
function pinv(A::StridedMatrix{T}) where T
1272+
function pinv(A::AbstractMatrix{T}) where T
12731273
rtol = eps(real(float(one(T))))*min(size(A)...)
12741274
return pinv(A, rtol)
12751275
end

stdlib/LinearAlgebra/test/dense.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,9 @@ bimg = randn(n,2)/2
8787
pinva15 = pinv(a[:,1:n1])
8888
@test a[:,1:n1]*pinva15*a[:,1:n1] a[:,1:n1]
8989
@test pinva15*a[:,1:n1]*pinva15 pinva15
90+
pinva15 = pinv(a[:,1:n1]') # the Adjoint case
91+
@test a[:,1:n1]'*pinva15*a[:,1:n1]' a[:,1:n1]'
92+
@test pinva15*a[:,1:n1]'*pinva15 pinva15
9093

9194
@test size(pinv(Matrix{eltya}(undef,0,0))) == (0,0)
9295
end

0 commit comments

Comments
 (0)