Skip to content

Commit 4b378ad

Browse files
committed
Link SuiteSparse against LBT when built in deps
1 parent 3301e4d commit 4b378ad

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

deps/openblas.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ endif
119119
endef
120120
$(eval $(call staged-install, \
121121
openblas,$(OPENBLAS_SRC_DIR), \
122-
OPENBLAS_INSTALL,$(BUILDDIR)/$(OPENBLAS_SRC_DIR)/$(LIBBLASNAME).$(SHLIB_EXT),, \
122+
OPENBLAS_INSTALL,$(BUILDDIR)/$(OPENBLAS_SRC_DIR)/libopenblas$$(OPENBLAS_LIBNAMESUFFIX).$$(SHLIB_EXT),, \
123123
$$(INSTALL_NAME_CMD)libopenblas$$(OPENBLAS_LIBNAMESUFFIX).$$(SHLIB_EXT) $$(build_shlibdir)/libopenblas$$(OPENBLAS_LIBNAMESUFFIX).$$(SHLIB_EXT)))
124124

125125
clean-openblas:

deps/suitesparse.mk

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,12 @@ ifeq ($(USE_BLAS64), 1)
44
UMFPACK_CONFIG := -DLONGBLAS='long long'
55
CHOLMOD_CONFIG := -DLONGBLAS='long long'
66
SPQR_CONFIG := -DLONGBLAS='long long'
7-
ifeq ($(OPENBLAS_SYMBOLSUFFIX), 64_)
87
UMFPACK_CONFIG += -DSUN64
98
CHOLMOD_CONFIG += -DSUN64
109
SPQR_CONFIG += -DSUN64
1110
endif
12-
endif
1311

14-
# Disable trying to link against libmetis
12+
# Disable linking to libmetis
1513
CHOLMOD_CONFIG += -DNPARTITION
1614

1715
ifneq ($(USE_BINARYBUILDER_SUITESPARSE), 1)
@@ -23,7 +21,7 @@ SUITE_SPARSE_LIB := $(LDFLAGS) -L"$(abspath $(BUILDDIR))/SuiteSparse-$(SUITESPAR
2321
ifeq ($(OS), Darwin)
2422
SUITE_SPARSE_LIB += $(RPATH_ESCAPED_ORIGIN)
2523
endif
26-
SUITESPARSE_MFLAGS := CC="$(CC)" CXX="$(CXX)" F77="$(FC)" AR="$(AR)" RANLIB="$(RANLIB)" BLAS="$(LIBBLAS)" LAPACK="$(LIBLAPACK)" \
24+
SUITESPARSE_MFLAGS := CC="$(CC)" CXX="$(CXX)" F77="$(FC)" AR="$(AR)" RANLIB="$(RANLIB)" BLAS="-L$(build_shlibdir) -lblastrampoline" LAPACK="-L$(build_shlibdir) -lblastrampoline" \
2725
LDFLAGS="$(SUITE_SPARSE_LIB)" CFOPENMP="" CUDA=no CUDA_PATH="" \
2826
UMFPACK_CONFIG="$(UMFPACK_CONFIG)" CHOLMOD_CONFIG="$(CHOLMOD_CONFIG)" SPQR_CONFIG="$(SPQR_CONFIG)"
2927
ifeq ($(OS),WINNT)
@@ -53,11 +51,7 @@ $(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/SuiteSparse-shlib.patch-applied: $(BU
5351
$(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/build-compiled: $(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/SuiteSparse-winclang.patch-applied
5452
$(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/build-compiled: $(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/SuiteSparse-shlib.patch-applied
5553

56-
ifeq ($(USE_SYSTEM_BLAS), 0)
57-
$(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/build-compiled: | $(build_prefix)/manifest/openblas
58-
else ifeq ($(USE_SYSTEM_LAPACK), 0)
59-
$(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/build-compiled: | $(build_prefix)/manifest/lapack
60-
endif
54+
$(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/build-compiled: | $(build_prefix)/manifest/blastrampoline
6155

6256
$(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/build-compiled: $(BUILDDIR)/SuiteSparse-$(SUITESPARSE_VER)/source-extracted
6357
$(MAKE) -C $(dir $<)SuiteSparse_config library config $(SUITESPARSE_MFLAGS)
@@ -153,6 +147,6 @@ clean-suitesparse-wrapper: clean-suitesparse
153147
distclean-suitesparse-wrapper: distclean-suitesparse
154148
install-suitesparse-wrapper: install-suitesparse
155149

156-
# suitesparse depends on OpenBLAS
157-
compile-suitesparse: | $(build_prefix)/manifest/openblas
150+
# suitesparse depends on blastrampoline
151+
compile-suitesparse: | $(build_prefix)/manifest/blastrampoline
158152
endif

0 commit comments

Comments
 (0)