Skip to content

Commit 678e55d

Browse files
committed
Fix USE_BINARYBUILDER_OPENBLAS=0 on macOS (#42538)
* Fix USE_BINARYBUILDER_OPENBLAS=0 on macOS We didn't properly move the OpenBLAS -> Objconv dependency chain over to manifest files. This was not visible until now because we rarely build OpenBLAS from source without also building Objconv from source. Fixes #42519 * Also update path to `objconv` binary (cherry picked from commit 6af7584)
1 parent 28921b3 commit 678e55d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

deps/blas.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ endif
4242
ifeq ($(USE_BLAS64), 1)
4343
OPENBLAS_BUILD_OPTS += INTERFACE64=1 SYMBOLSUFFIX="$(OPENBLAS_SYMBOLSUFFIX)" LIBPREFIX="libopenblas$(OPENBLAS_LIBNAMESUFFIX)"
4444
ifeq ($(OS), Darwin)
45-
OPENBLAS_BUILD_OPTS += OBJCONV=$(abspath $(BUILDDIR)/objconv/objconv)
46-
$(BUILDDIR)/$(OPENBLAS_SRC_DIR)/build-compiled: | $(BUILDDIR)/objconv/build-compiled
45+
OPENBLAS_BUILD_OPTS += OBJCONV=$(abspath $(build_bindir)/objconv)
46+
$(BUILDDIR)/$(OPENBLAS_SRC_DIR)/build-compiled: | $(build_prefix)/manifest/objconv
4747
endif
4848
endif
4949

0 commit comments

Comments
 (0)