Skip to content

Commit 69e4dee

Browse files
authored
preserve and test more existing behaviors
1 parent fd531e4 commit 69e4dee

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

base/reduce.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -339,6 +339,8 @@ reduce_empty(::typeof(+), ::Type{T}) where {T} = zero(T)
339339
reduce_empty(::typeof(+), ::Type{Bool}) = zero(Int)
340340
reduce_empty(::typeof(*), ::Type{T}) where {T} = one(T)
341341
reduce_empty(::typeof(*), ::Type{<:AbstractChar}) = ""
342+
reduce_empty(::typeof(&), ::Type{Bool}) = true
343+
reduce_empty(::typeof(|), ::Type{Bool}) = false
342344
reduce_empty(::typeof(and_all), ::Type{T}) where {T} = true
343345
reduce_empty(::typeof(or_any), ::Type{T}) where {T} = false
344346

test/reduce.jl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -686,6 +686,10 @@ end
686686
@test any([true, true, true], dims = 1) == [true]
687687
@test_throws TypeError all([3, 3, 3], dims = 1)
688688
@test_throws TypeError any([3, 3, 3], dims = 1)
689+
@test reduce(|, Bool[]) == false
690+
@test reduce(&, Bool[]) == true
691+
@test reduce(|, Bool[], dims=1) == [false]
692+
@test reduce(&, Bool[], dims=1) == [true]
689693
end
690694

691695
# issue #45748

0 commit comments

Comments
 (0)