Disambiguate mul!(::Matrix, ::Diagonal, ::Adjoint)

and mul!(::Matrix, ::Diagonal, ::Transpose) as well.

Author: tkf

stdlib/LinearAlgebra/src/diagonal.jl

@@ -272,6 +272,9 @@ mul!(out::AbstractMatrix, A::Diagonal, in::AbstractMatrix) = out .= A.diag .* in
 mul!(out::AbstractMatrix, A::Adjoint{<:Any,<:Diagonal}, in::AbstractMatrix) = out .= adjoint.(A.parent.diag) .* in
 mul!(out::AbstractMatrix, A::Transpose{<:Any,<:Diagonal}, in::AbstractMatrix) = out .= transpose.(A.parent.diag) .* in
 
+mul!(out::AbstractMatrix, A::Diagonal, in::Adjoint{<:Any,<:AbstractMatrix}) = out .= A.diag .* in
+mul!(out::AbstractMatrix, A::Diagonal, in::Transpose{<:Any,<:AbstractMatrix}) = out .= A.diag .* in
+
 # ambiguities with Symmetric/Hermitian
 # RealHermSymComplex[Sym]/[Herm] only include Number; invariant to [c]transpose
 *(A::Diagonal, transB::Transpose{<:Any,<:RealHermSymComplexSym}) = A * transB.parent

stdlib/LinearAlgebra/test/diagonal.jl

@@ -176,6 +176,10 @@ srand(1)
         @test (r = Matrix(D)' * UU  ; mul!(UUU, adjoint(D), UU) ≈ r ≈ UUU)
         @test (r = transpose(Matrix(D)) * UU ; mul!(UUU, transpose(D), UU) ≈ r ≈ UUU)
 
+        # Performance specialisations / ambiguity checks for A_mul_B*!
+        @test (r = Matrix(D) * UU' ; mul!(UUU, D, adjoint(UU)) ≈ r ≈ UUU)
+        @test (r = Matrix(D) * transpose(UU) ; mul!(UUU, D, transpose(UU)) ≈ r ≈ UUU)
+
         # make sure that mul!(A, {Adj|Trans}(B)) works with B as a Diagonal
         VV = Array(D)
         DD = copy(D)