Skip to content

Commit 73f1cd3

Browse files
jakobnissenKristofferC
authored andcommitted
Fix typo in BitVector constructor (#39737)
(cherry picked from commit f07b12b)
1 parent ae95fcc commit 73f1cd3

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

base/bitarray.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,7 @@ gen_bitarrayN(::Type{BitVector}, itsz, itr) = gen_bitarra
605605
gen_bitarrayN(::Type{BitVector}, itsz::HasShape{1}, itr) = gen_bitarray(itsz, itr)
606606
gen_bitarrayN(::Type{BitArray{N}}, itsz::HasShape{N}, itr) where N = gen_bitarray(itsz, itr)
607607
# The first of these is just for ambiguity resolution
608-
gen_bitarrayN(::Type{BitVector}, itsz::HasShape{N}, itr) where N = throw(DimensionMismatch("cannot create a $T from a $N-dimensional iterator"))
608+
gen_bitarrayN(::Type{BitVector}, itsz::HasShape{N}, itr) where N = throw(DimensionMismatch("cannot create a BitVector from a $N-dimensional iterator"))
609609
gen_bitarrayN(@nospecialize(T::Type), itsz::HasShape{N}, itr) where N = throw(DimensionMismatch("cannot create a $T from a $N-dimensional iterator"))
610610
gen_bitarrayN(@nospecialize(T::Type), itsz, itr) = throw(DimensionMismatch("cannot create a $T from a generic iterator"))
611611

test/bitarray.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,9 @@ timesofar("utils")
198198
((x+y)%5==2 for x = 1:n1 for y = 1:n2))
199199
@test BitArray(g) == BitArray(collect(g))
200200
end
201+
@test_throws DimensionMismatch BitVector(false)
202+
@test_throws DimensionMismatch BitVector((iszero(i%4) for i in 1:n1, j in 1:n2))
203+
@test_throws DimensionMismatch BitMatrix((isodd(i) for i in 1:3))
201204
end
202205

203206
@testset "constructor from NTuple" begin

0 commit comments

Comments
 (0)