Skip to content

Commit 97ac3ec

Browse files
authored
make view(::Memory, ::Colon) produce a Vector (#54005)
1 parent 7099bdd commit 97ac3ec

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

base/genericmemory.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -312,3 +312,4 @@ end
312312
$(Expr(:new, :(Array{T, 1}), :ref, :dims))
313313
end
314314
end
315+
view(m::GenericMemory, inds::Colon) = view(m, eachindex(m))

test/arrayops.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3203,6 +3203,7 @@ end
32033203
@test @inferred(view(mem, 3:8))::Vector{Int} == 13:18
32043204
@test @inferred(view(mem, 20:19))::Vector{Int} == []
32053205
@test @inferred(view(mem, -5:-7))::Vector{Int} == []
3206+
@test @inferred(view(mem, :))::Vector{Int} == mem
32063207
@test @inferred(reshape(mem, 5, 2))::Matrix{Int} == reshape(11:20, 5, 2)
32073208

32083209
# 53990
@@ -3217,6 +3218,7 @@ end
32173218

32183219
@test @inferred(view(empty_mem, 1:0))::Vector{Module} == []
32193220
@test @inferred(view(empty_mem, 10:3))::Vector{Module} == []
3221+
@test @inferred(view(empty_mem, :))::Vector{Module} == empty_mem
32203222
@test isempty(@inferred(reshape(empty_mem, 0, 7, 1))::Array{Module, 3})
32213223

32223224
offset_inds = OffsetArrays.IdOffsetRange(values=3:6, indices=53:56)

0 commit comments

Comments
 (0)