Get rid of all invalidations

Author: rikhuijzer

base/logging.jl

@@ -677,7 +677,7 @@ function handle_message(logger::SimpleLogger, level::LogLevel, message, _module,
     end
     iob = IOContext(buf, stream)
     levelstr = level == Warn ? "Warning" : string(level)
-    msglines = eachsplit(chomp(string(message)::String), '\n')
+    msglines = eachsplit(chomp(convert(String, string(message))::String), '\n')
     msg1, rest = Iterators.peel(msglines)
     println(iob, "┌ ", levelstr, ": ", msg1)
     for msg in rest

base/show.jl

@@ -2006,7 +2006,7 @@ function show_unquoted(io::IO, ex::Expr, indent::Int, prec::Int, quote_level::In
             na = length(func_args)
             if (na == 2 || (na > 2 && isa(func, Symbol) && func in (:+, :++, :*)) || (na == 3 && func === :(:))) &&
                     all(a -> !isa(a, Expr) || a.head !== :..., func_args)
-                sep = func === :(:) ? "$func" : " " * string(func)::String * " "   # if func::Any, avoid string interpolation (invalidation)
+                sep = func === :(:) ? "$func" : " " * convert(String, string(func))::String * " "   # if func::Any, avoid string interpolation (invalidation)
 
                 if func_prec <= prec
                     show_enclosed_list(io, '(', func_args, sep, ')', indent, func_prec, quote_level, true)

base/strings/basic.jl

@@ -229,7 +229,7 @@ Symbol(s::AbstractString) = Symbol(String(s))
 Symbol(x...) = Symbol(string(x...))
 
 convert(::Type{T}, s::T) where {T<:AbstractString} = s
-convert(::Type{T}, s::AbstractString) where {T<:AbstractString} = T(s)::T
+convert(::Type{T}, s::AbstractString) where {T<:AbstractString} = T(s)
 
 ## summary ##
 

stdlib/Logging/src/ConsoleLogger.jl

@@ -116,7 +116,7 @@ function handle_message(logger::ConsoleLogger, level::LogLevel, message, _module
 
     # Generate a text representation of the message and all key value pairs,
     # split into lines.
-    msglines = [(indent=0, msg=l) for l in split(chomp(string(message)::String), '\n')]
+    msglines = [(indent=0, msg=l) for l in split(chomp(convert(String, string(message))::String), '\n')]
     stream::IO = logger.stream
     if !(isopen(stream)::Bool)
         stream = stderr

stdlib/REPL/src/REPL.jl

@@ -566,33 +566,6 @@ mutable struct REPLHistoryProvider <: HistoryProvider
     last_mode::Union{Nothing,Prompt}
     mode_mapping::Dict{Symbol,Prompt}
     modes::Vector{Symbol}
-
-    # Explicit constructor to avoid `convert` invalidations.
-    function REPLHistoryProvider(
-            history,
-            file_path::AbstractString,
-            history_file,
-            start_idx,
-            cur_idx,
-            last_idx,
-            last_buffer,
-            last_mode,
-            mode_mapping,
-            modes
-        )
-        new(
-            history,
-            file_path,
-            history_file,
-            start_idx,
-            cur_idx,
-            last_idx,
-            last_buffer,
-            last_mode,
-            mode_mapping,
-            modes
-        )
-    end
 end
 REPLHistoryProvider(mode_mapping::Dict{Symbol}) =
     REPLHistoryProvider(String[], "", nothing, 0, 0, -1, IOBuffer(),

test/invalidations.jl

@@ -4,7 +4,6 @@ isdefined(Main, :MethodInvalidations) || @eval Main include(joinpath($(BASE_TEST
 import Base
 
 using .Main.MethodInvalidations
-using REPL: REPL
 
 f(x) = x
 g(x) = f(x)
@@ -18,6 +17,4 @@ invs = @method_invalidations f(x::Int) = 2x
 struct X end
 
 invs = @method_invalidations Base.convert(::Type{String}, ::X) = X()
-@test !invalidated(invs, Base.show_unquoted)
-@test !invalidated(invs, REPL.REPLHistoryProvider)
-@test !invalidated(invs, Base.CoreLogging.handle_message)
+@test length(uinvalidated(invs)) == 0