Merge pull request #45319 from JuliaLang/backports-release-1.6

release-1.6: Backports for 1.6.7

Author: KristofferC

.buildkite/pipelines/main/misc/doctest.yml

@@ -3,6 +3,7 @@ agents:
   # Only run on `sandbox.jl` machines (not `docker`-isolated ones) since we need nestable sandboxing
   sandbox.jl: "true"
   os: "linux"
+  arch: "x86_64"
 steps:
   - label: "doctest"
     key: doctest

.buildkite/pipelines/main/misc/embedding.yml

@@ -3,6 +3,7 @@ agents:
   # Only run on `sandbox.jl` machines (not `docker`-isolated ones) since we need nestable sandboxing
   sandbox.jl: "true"
   os: "linux"
+  arch: "x86_64"
 steps:
   - label: "embedding"
     key: "embedding"

.buildkite/pipelines/main/misc/llvmpasses.yml

@@ -3,6 +3,7 @@ agents:
   # Only run on `sandbox.jl` machines (not `docker`-isolated ones) since we need nestable sandboxing
   sandbox.jl: "true"
   os: "linux"
+  arch: "x86_64"
 steps:
   - label: "analyzegc"
     key: "analyzegc"

.buildkite/pipelines/main/misc/sanitizers.yml

@@ -3,6 +3,7 @@ agents:
   # Only run on `sandbox.jl` machines (not `docker`-isolated ones) since we need nestable sandboxing
   sandbox.jl: "true"
   os: "linux"
+  arch: "x86_64"
 steps:
   - label: "asan"
     key: "asan"

.buildkite/pipelines/main/misc/whitespace.yml

@@ -3,6 +3,7 @@ agents:
   # Only run on `sandbox.jl` machines (not `docker`-isolated ones) since we need nestable sandboxing
   sandbox.jl: "true"
   os: "linux"
+  arch: "x86_64"
 steps:
   - label: "whitespace"
     key: "whitespace"

.buildkite/pipelines/main/platforms/package_linux.yml

@@ -3,6 +3,7 @@ agents:
   # Only run on `sandbox.jl` machines (not `docker`-isolated ones) since we need nestable sandboxing
   sandbox.jl: "true"
   os: "linux"
+  arch: "x86_64"
 steps:
   - label: "package_${PLATFORM?}${LABEL?}"
     key: package_${PLATFORM?}${LABEL?}

.buildkite/pipelines/main/platforms/tester_linux.yml

@@ -3,6 +3,7 @@ agents:
   # Only run on `sandbox.jl` machines (not `docker`-isolated ones) since we need nestable sandboxing
   sandbox.jl: "true"
   os: "linux"
+  arch: "x86_64"
 steps:
   - label: "tester_${PLATFORM?}${LABEL?}"
     key: tester_${PLATFORM?}${LABEL?}

NEWS.md

@@ -102,8 +102,13 @@ New library functions
 * New function `Base.rest` for taking the rest of a collection, starting from a specific
   iteration state, in a generic way ([#37410]).
 
-New library features
---------------------
+Library changes
+---------------
+
+* A known concurrency issue of `iterate` methods on `Dict` and other derived objects such
+  as `keys(::Dict)`, `values(::Dict)`, and `Set` is fixed.  These methods of `iterate` can
+  now be called on a dictionary or set shared by arbitrary tasks provided that there are no
+  tasks mutating the dictionary or set ([#44534]).
 
 * The `redirect_*` functions now accept `devnull` to discard all output redirected to it, and as an empty
   input ([#36146]).

base/dict.jl

@@ -683,7 +683,7 @@ end
 
 @propagate_inbounds _iterate(t::Dict{K,V}, i) where {K,V} = i == 0 ? nothing : (Pair{K,V}(t.keys[i],t.vals[i]), i == typemax(Int) ? 0 : i+1)
 @propagate_inbounds function iterate(t::Dict)
-    _iterate(t, skip_deleted_floor!(t))
+    _iterate(t, skip_deleted(t, t.idxfloor))
 end
 @propagate_inbounds iterate(t::Dict, i) = _iterate(t, skip_deleted(t, i))
 

base/essentials.jl

@@ -538,7 +538,7 @@ element `i` of array `A` is skipped to improve performance.
 ```julia
 function sum(A::AbstractArray)
     r = zero(eltype(A))
-    for i = 1:length(A)
+    for i in eachindex(A)
         @inbounds r += A[i]
     end
     return r