Skip to content

Commit b0ede0a

Browse files
committed
apply the constructing functions to some code under base/
1 parent 41a456b commit b0ede0a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

63 files changed

+366
-344
lines changed

base/abstractarray.jl

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,8 @@ If multiple arguments are passed, equivalent to `has_offset_axes(A) || has_offse
108108
See also [`require_one_based_indexing`](@ref).
109109
"""
110110
has_offset_axes() = false
111-
has_offset_axes(A) = _any_tuple(x->Int(first(x))::Int != 1, false, axes(A)...)
112-
has_offset_axes(A::AbstractVector) = Int(firstindex(A))::Int != 1 # improve performance of a common case (ranges)
111+
has_offset_axes(A) = _any_tuple(!=(1) _Int first, false, axes(A)...)
112+
has_offset_axes(A::AbstractVector) = _Int(firstindex(A)) != 1 # improve performance of a common case (ranges)
113113
has_offset_axes(::Colon) = false
114114
has_offset_axes(::Array) = false
115115
# note: this could call `any` directly if the compiler can infer it. We don't use _any_tuple
@@ -212,8 +212,8 @@ String
212212
"""
213213
valtype(A::Type{<:AbstractArray}) = eltype(A)
214214

215-
prevind(::AbstractArray, i::Integer) = Int(i)-1
216-
nextind(::AbstractArray, i::Integer) = Int(i)+1
215+
prevind(::AbstractArray, i::Integer) = _Int(i)-1
216+
nextind(::AbstractArray, i::Integer) = _Int(i)+1
217217

218218

219219
"""
@@ -838,10 +838,10 @@ to_shape(dims::Dims) = dims
838838
to_shape(dims::DimsOrInds) = map(to_shape, dims)::DimsOrInds
839839
# each dimension
840840
to_shape(i::Int) = i
841-
to_shape(i::Integer) = Int(i)
841+
to_shape(i::Integer) = _Int(i)
842842
to_shape(r::AbstractOneTo) = _to_shape(last(r))
843843
_to_shape(x::Integer) = to_shape(x)
844-
_to_shape(x) = Int(x)
844+
_to_shape(x) = _Int(x)
845845
to_shape(r::AbstractUnitRange) = r
846846

847847
"""
@@ -951,7 +951,7 @@ function copyto!(dest::AbstractArray, src)
951951
end
952952

953953
function copyto!(dest::AbstractArray, dstart::Integer, src)
954-
i = Int(dstart)
954+
i = _Int(dstart)
955955
if haslength(src) && length(dest) > 0
956956
@boundscheck checkbounds(dest, i:(i + length(src) - 1))
957957
for x in src
@@ -986,7 +986,7 @@ function copyto!(dest::AbstractArray, dstart::Integer, src, sstart::Integer)
986986
"source has fewer elements than required, ",
987987
"expected at least ",sstart," got ", sstart-1)))
988988
end
989-
i = Int(dstart)
989+
i = _Int(dstart)
990990
while y !== nothing
991991
val, st = y
992992
dest[i] = val
@@ -1023,7 +1023,7 @@ function copyto!(dest::AbstractArray, dstart::Integer, src, sstart::Integer, n::
10231023
"expected at least ",sstart," got ", sstart-1)))
10241024
end
10251025
val, st = y
1026-
i = Int(dstart)
1026+
i = _Int(dstart)
10271027
@inbounds dest[i] = val
10281028
for val in Iterators.take(Iterators.rest(src, st), n-1)
10291029
i += 1
@@ -1269,7 +1269,7 @@ end
12691269
pointer(x::AbstractArray{T}) where {T} = unsafe_convert(Ptr{T}, cconvert(Ptr{T}, x))
12701270
function pointer(x::AbstractArray{T}, i::Integer) where T
12711271
@inline
1272-
pointer(x) + Int(_memory_offset(x, i))::Int
1272+
pointer(x) + _Int(_memory_offset(x, i))::Int
12731273
end
12741274

12751275
# The distance from pointer(x) to the element at x[I...] in bytes
@@ -1601,8 +1601,8 @@ parts can specialize this method to return the concatenation of the `dataids` of
16011601
their component parts. A typical definition for an array that wraps a parent is
16021602
`Base.dataids(C::CustomArray) = dataids(C.parent)`.
16031603
"""
1604-
dataids(A::AbstractArray) = (UInt(objectid(A)),)
1605-
dataids(A::Memory) = (UInt(A.ptr),)
1604+
dataids(A::AbstractArray) = (_UInt(objectid(A)),)
1605+
dataids(A::Memory) = (_UInt(A.ptr),)
16061606
dataids(A::Array) = dataids(A.ref.mem)
16071607
dataids(::AbstractRange) = ()
16081608
dataids(x) = ()
@@ -1702,9 +1702,9 @@ _typed_vcat(::Type{T}, V::AbstractVecOrTuple{AbstractVector}) where T =
17021702

17031703
function _typed_vcat!(a::AbstractVector{T}, V::AbstractVecOrTuple{AbstractVector}) where T
17041704
pos = 1
1705-
for k=1:Int(length(V))::Int
1705+
for k=1:_Int(length(V))::Int
17061706
Vk = V[k]
1707-
p1 = pos + Int(length(Vk))::Int - 1
1707+
p1 = pos + _Int(length(Vk))::Int - 1
17081708
a[pos:p1] = Vk
17091709
pos = p1+1
17101710
end

base/abstractarraymath.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ function _dropdims(A::AbstractArray, dims::Dims)
9191
ax = _foldoneto((ds, d) -> d in dims ? ds : (ds..., axes(A,d)), (), Val(ndims(A)))
9292
reshape(A, ax::typeof(_sub(axes(A), dims)))
9393
end
94-
_dropdims(A::AbstractArray, dim::Integer) = _dropdims(A, (Int(dim),))
94+
_dropdims(A::AbstractArray, dim::Integer) = _dropdims(A, (_Int(dim),))
9595

9696

9797
"""
@@ -153,7 +153,7 @@ function _insertdims(A::AbstractArray{T, N}, dims::NTuple{M, Int}) where {T, N,
153153
new_shape = inds[1]
154154
return reshape(A, new_shape)
155155
end
156-
_insertdims(A::AbstractArray, dim::Integer) = _insertdims(A, (Int(dim),))
156+
_insertdims(A::AbstractArray, dim::Integer) = _insertdims(A, (_Int(dim),))
157157

158158

159159

base/abstractset.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ max_values(::Type{Bool}) = 2
101101
max_values(::Type{Nothing}) = 1
102102

103103
function union!(s::AbstractSet{T}, itr) where T
104-
haslength(itr) && sizehint!(s, length(s) + Int(length(itr))::Int; shrink = false)
104+
haslength(itr) && sizehint!(s, length(s) + _Int(length(itr)); shrink = false)
105105
for x in itr
106106
push!(s, x)
107107
length(s) == max_values(T) && break

base/array.jl

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ function vect(X...)
185185
return T[X...]
186186
end
187187

188-
size(a::Array, d::Integer) = size(a, Int(d)::Int)
188+
size(a::Array, d::Integer) = size(a, _Int(d))
189189
function size(a::Array, d::Int)
190190
d < 1 && error("arraysize: dimension out of range")
191191
sz = getfield(a, :size)
@@ -672,7 +672,7 @@ _similar_for(c::AbstractArray, ::Type{T}, itr, ::HasShape, axs) where {T} =
672672

673673
# make a collection appropriate for collecting `itr::Generator`
674674
_array_for(::Type{T}, ::SizeUnknown, ::Nothing) where {T} = Vector{T}(undef, 0)
675-
_array_for(::Type{T}, ::HasLength, len::Integer) where {T} = Vector{T}(undef, Int(len))
675+
_array_for(::Type{T}, ::HasLength, len::Integer) where {T} = Vector{T}(undef, _Int(len))
676676
_array_for(::Type{T}, ::HasShape{N}, axs) where {T,N} = similar(Array{T,N}, axs)
677677

678678
# used by syntax lowering for simple typed comprehensions
@@ -1112,7 +1112,7 @@ end
11121112

11131113
function _growbeg!(a::Vector, delta::Integer)
11141114
@_noub_meta
1115-
delta = Int(delta)
1115+
delta = _Int(delta)
11161116
delta == 0 && return # avoid attempting to index off the end
11171117
delta >= 0 || throw(ArgumentError("grow requires delta >= 0"))
11181118
ref = a.ref
@@ -1167,7 +1167,7 @@ end
11671167

11681168
function _growend!(a::Vector, delta::Integer)
11691169
@_noub_meta
1170-
delta = Int(delta)
1170+
delta = _Int(delta)
11711171
delta >= 0 || throw(ArgumentError("grow requires delta >= 0"))
11721172
ref = a.ref
11731173
mem = ref.mem
@@ -1185,8 +1185,8 @@ end
11851185

11861186
function _growat!(a::Vector, i::Integer, delta::Integer)
11871187
@_terminates_globally_noub_meta
1188-
delta = Int(delta)
1189-
i = Int(i)
1188+
delta = _Int(delta)
1189+
i = _Int(i)
11901190
i == 1 && return _growbeg!(a, delta)
11911191
len = length(a)
11921192
i == len + 1 && return _growend!(a, delta)
@@ -1230,7 +1230,7 @@ end
12301230

12311231
# efficiently delete part of an array
12321232
function _deletebeg!(a::Vector, delta::Integer)
1233-
delta = Int(delta)
1233+
delta = _Int(delta)
12341234
len = length(a)
12351235
0 <= delta <= len || throw(ArgumentError("_deletebeg! requires delta in 0:length(a)"))
12361236
for i in 1:delta
@@ -1245,7 +1245,7 @@ function _deletebeg!(a::Vector, delta::Integer)
12451245
return
12461246
end
12471247
function _deleteend!(a::Vector, delta::Integer)
1248-
delta = Int(delta)
1248+
delta = _Int(delta)
12491249
len = length(a)
12501250
0 <= delta <= len || throw(ArgumentError("_deleteend! requires delta in 0:length(a)"))
12511251
newlen = len - delta
@@ -1256,7 +1256,7 @@ function _deleteend!(a::Vector, delta::Integer)
12561256
return
12571257
end
12581258
function _deleteat!(a::Vector, i::Integer, delta::Integer)
1259-
i = Int(i)
1259+
i = _Int(i)
12601260
len = length(a)
12611261
0 <= delta || throw(ArgumentError("_deleteat! requires delta >= 0"))
12621262
1 <= i <= len || throw(BoundsError(a, i))
@@ -1372,7 +1372,7 @@ function append! end
13721372

13731373
function append!(a::Vector{T}, items::Union{AbstractVector{<:T},Tuple}) where T
13741374
items isa Tuple && (items = map(x -> convert(T, x), items))
1375-
n = Int(length(items))::Int
1375+
n = _Int(length(items))
13761376
_growend!(a, n)
13771377
copyto!(a, length(a)-n+1, items, firstindex(items), n)
13781378
return a
@@ -1383,7 +1383,7 @@ push!(a::AbstractVector, iter...) = append!(a, iter)
13831383
append!(a::AbstractVector, iter...) = (foreach(v -> append!(a, v), iter); a)
13841384

13851385
function _append!(a::AbstractVector, ::Union{HasLength,HasShape}, iter)
1386-
n = Int(length(iter))::Int
1386+
n = _Int(length(iter))
13871387
i = lastindex(a)
13881388
sizehint!(a, length(a) + n; shrink=false)
13891389
for item in iter
@@ -1446,7 +1446,7 @@ prepend!(a::AbstractVector, iter...) = (for v = reverse(iter); prepend!(a, v); e
14461446
function _prepend!(a::Vector, ::Union{HasLength,HasShape}, iter)
14471447
@_terminates_locally_meta
14481448
require_one_based_indexing(a)
1449-
n = Int(length(iter))::Int
1449+
n = _Int(length(iter))
14501450
sizehint!(a, length(a) + n; first=true, shrink=false)
14511451
n = 0
14521452
for item in iter
@@ -1497,7 +1497,7 @@ julia> a[1:6]
14971497
```
14981498
"""
14991499
function resize!(a::Vector, nl_::Integer)
1500-
nl = Int(nl_)::Int
1500+
nl = _Int(nl_)
15011501
l = length(a)
15021502
if nl > l
15031503
_growend!(a, nl-l)
@@ -1551,7 +1551,7 @@ function sizehint!(a::Vector, sz::Integer; first::Bool=false, shrink::Bool=true)
15511551
ref = a.ref
15521552
mem = ref.mem
15531553
memlen = length(mem)
1554-
sz = max(Int(sz), len)
1554+
sz = max(_Int(sz), len)
15551555
inc = sz - len
15561556
if sz <= memlen
15571557
# if we don't save at least 1/8th memlen then its not worth it to shrink
@@ -2185,7 +2185,7 @@ julia> reverse(A, 3, 5)
21852185
```
21862186
"""
21872187
function reverse(A::AbstractVector, start::Integer, stop::Integer=lastindex(A))
2188-
s, n = Int(start), Int(stop)
2188+
s, n = _Int(start), _Int(stop)
21892189
B = similar(A)
21902190
for i = firstindex(A):s-1
21912191
B[i] = A[i]
@@ -2249,7 +2249,7 @@ julia> A
22492249
```
22502250
"""
22512251
function reverse!(v::AbstractVector, start::Integer, stop::Integer=lastindex(v))
2252-
s, n = Int(start), Int(stop)
2252+
s, n = _Int(start), _Int(stop)
22532253
if n > s # non-empty and non-trivial
22542254
liv = LinearIndices(v)
22552255
if !(first(liv) s last(liv))
@@ -3196,12 +3196,12 @@ end
31963196
$(Expr(:new, :(Array{T, N}), :ref, :dims))
31973197
end
31983198
@eval @propagate_inbounds function wrap(::Type{Array}, m::MemoryRef{T}, l::Integer) where {T}
3199-
dims = (Int(l),)
3199+
dims = (_Int(l),)
32003200
ref = _wrap(m, dims)
32013201
$(Expr(:new, :(Array{T, 1}), :ref, :dims))
32023202
end
32033203
@eval @propagate_inbounds function wrap(::Type{Array}, m::Memory{T}, l::Integer) where {T}
3204-
dims = (Int(l),)
3204+
dims = (_Int(l),)
32053205
ref = _wrap(memoryref(m), (l,))
32063206
$(Expr(:new, :(Array{T, 1}), :ref, :dims))
32073207
end

base/arraymath.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ Like [`reverse`](@ref), but operates in-place in `A`.
6969
"""
7070
reverse!(A::AbstractArray; dims=:) = _reverse!(A, dims)
7171
_reverse!(A::AbstractArray{<:Any,N}, ::Colon) where {N} = _reverse!(A, ntuple(identity, Val{N}()))
72-
_reverse!(A, dim::Integer) = _reverse!(A, (Int(dim),))
72+
_reverse!(A, dim::Integer) = _reverse!(A, (_Int(dim),))
7373
_reverse!(A, dims::NTuple{M,Integer}) where {M} = _reverse!(A, Int.(dims))
7474
function _reverse!(A::AbstractArray{<:Any,N}, dims::NTuple{M,Int}) where {N,M}
7575
dims === () && return A # nothing to reverse

base/arrayshow.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ function print_matrix(io::IO, X::AbstractVecOrMat,
172172
end
173173

174174
function _print_matrix(io, @nospecialize(X::AbstractVecOrMat), pre, sep, post, hdots, vdots, ddots, hmod, vmod, rowsA, colsA)
175-
hmod, vmod = Int(hmod)::Int, Int(vmod)::Int
175+
hmod, vmod = _Int(hmod), _Int(vmod)
176176
ncols, idxlast = length(colsA), last(colsA)
177177
if !(get(io, :limit, false)::Bool)
178178
screenheight = screenwidth = typemax(Int)

base/binaryplatforms.jl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ export AbstractPlatform, Platform, HostPlatform, platform_dlext, tags, arch, os,
88
detect_libstdcxx_version, detect_cxxstring_abi, call_abi, wordsize, triplet,
99
select_platform, platforms_match, platform_name
1010
import .Libc.Libdl
11+
using .._ConstructingFunctions
1112

1213
### Submodule with information about CPU features
1314
include("cpuid.jl")
@@ -116,7 +117,7 @@ function Platform(arch::String, os::String;
116117
validate_strict::Bool = false,
117118
compare_strategies::Dict{String,<:Function} = Dict{String,Function}(),
118119
kwargs...)
119-
tags = Dict{String,Any}(String(tag)::String=>tagvalue(value) for (tag, value) in kwargs)
120+
tags = Dict{String,Any}(_String(tag)=>tagvalue(value) for (tag, value) in kwargs)
120121
return Platform(arch, os, tags; validate_strict, compare_strategies)
121122
end
122123

@@ -740,7 +741,7 @@ function Base.parse(::Type{Platform}, triplet::String; validate_strict::Bool = f
740741
if isempty(tag_fields)
741742
return Pair{String,String}[]
742743
end
743-
return map(v -> String(v[1]) => String(v[2]), split.(tag_fields, "+"))
744+
return map(v -> _String(v[1]) => _String(v[2]), split.(tag_fields, "+"))
744745
end
745746
merge!(tags, Dict(split_tags(m["tags"])))
746747

0 commit comments

Comments
 (0)