deprecate replace(s::String, pat, r, n) to replace(s, pat=>r, count=n)

Author: rfourquet

base/deprecated.jl

@@ -1344,14 +1344,19 @@ end
 function replace(s::AbstractString, pat, f, n::Integer)
     if n <= 0
         depwarn(string("`replace(s, pat, r, count)` with `count <= 0` is deprecated, use ",
-                       "`replace(s, pat, r, typemax(Int))` or `replace(s, pat, r)` instead"),
+                       "`replace(s, pat=>r, count=typemax(Int))` or `replace(s, pat=>r)` instead"),
                 :replace)
-        replace(s, pat, f)
+        replace(s, pat=>f)
     else
-        replace_new(String(s), pat, f, n)
+        depwarn(string("`replace(s, pat, r, count)` is deprecated, use ",
+                       "`replace(s, pat=>r, count=count)`"),
+                :replace)
+        replace(String(s), pat=>f, count=n)
     end
 end
 
+@deprecate replace(s::AbstractString, pat, f) replace(s, pat=>f)
+
 # PR #22475
 @deprecate ntuple(f, ::Type{Val{N}}) where {N}  ntuple(f, Val(N))
 @deprecate fill_to_length(t, val, ::Type{Val{N}}) where {N} fill_to_length(t, val, Val(N)) false

base/libgit2/utils.jl

@@ -83,7 +83,7 @@ Standardise the path string `path` to use POSIX separators.
 """
 function posixpath end
 if Sys.iswindows()
-    posixpath(path) = replace(path,'\\','/')
+    posixpath(path) = replace(path,'\\' => '/')
 elseif Sys.isunix()
     posixpath(path) = path
 end

base/markdown/GitHub/table.jl

@@ -11,7 +11,7 @@ function parserow(stream::IO)
         row = split(line, r"(?<!\\)\|")
         length(row) == 1 && return
         isempty(row[1]) && shift!(row)
-        map!(x -> strip(replace(x, "\\|", "|")), row, row)
+        map!(x -> strip(replace(x, "\\|" => "|")), row, row)
         isempty(row[end]) && pop!(row)
         return row
     end
@@ -104,7 +104,7 @@ _dash(width, align) =
 
 function plain(io::IO, md::Table)
     cells = mapmap(md.rows) do each
-        replace(plaininline(each), "|", "\\|")
+        replace(plaininline(each), "|" => "\\|")
     end
     padcells!(cells, md.align, len = length, min = 3)
     for i = axes(cells,1)

base/markdown/render/html.jl

@@ -31,7 +31,7 @@ for ch in "'`!\$%()=+{}[]"
 end
 
 function htmlesc(io::IO, s::AbstractString)
-    # s1 = replace(s, r"&(?!(\w+|\#\d+);)", "&")
+    # s1 = replace(s, r"&(?!(\w+|\#\d+);)" => "&")
     for ch in s
         print(io, get(_htmlescape_chars, ch, ch))
     end

base/markdown/render/rst.jl

@@ -124,7 +124,7 @@ end
 
 rstinline(io::IO, f::Footnote) = print(io, "[", f.id, "]_")
 
-rstescape(s) = replace(s, "\\", "\\\\")
+rstescape(s) = replace(s, "\\" => "\\\\")
 
 rstinline(io::IO, s::AbstractString) = print(io, rstescape(s))
 

base/markdown/render/terminal/formatting.jl

@@ -51,7 +51,7 @@ end
 # Wrapping
 
 function ansi_length(s)
-    replace(s, r"\e\[[0-9]+m", "") |> length
+    replace(s, r"\e\[[0-9]+m" => "") |> length
 end
 
 words(s) = split(s, " ")

base/markdown/render/terminal/render.jl

@@ -114,7 +114,7 @@ function terminline(io::IO, content::Vector)
 end
 
 function terminline(io::IO, md::AbstractString)
-    print(io, replace(md, r"[\s\t\n]+", " "))
+    print(io, replace(md, r"[\s\t\n]+" => " "))
 end
 
 function terminline(io::IO, md::Bold)

base/methodshow.jl

@@ -203,7 +203,7 @@ function url(m::Method)
     file = string(m.file)
     line = m.line
     line <= 0 || ismatch(r"In\[[0-9]+\]", file) && return ""
-    Sys.iswindows() && (file = replace(file, '\\', '/'))
+    Sys.iswindows() && (file = replace(file, '\\' => '/'))
     if inbase(M)
         if isempty(Base.GIT_VERSION_INFO.commit)
             # this url will only work if we're on a tagged release

base/pkg/reqs.jl

@@ -19,7 +19,7 @@ struct Requirement <: Line
     system::Vector{AbstractString}
 
     function Requirement(content::AbstractString)
-        fields = split(replace(content, r"#.*$", ""))
+        fields = split(replace(content, r"#.*$" => ""))
         system = AbstractString[]
         while !isempty(fields) && fields[1][1] == '@'
             push!(system,shift!(fields)[2:end])

base/process.jl

@@ -107,7 +107,7 @@ function show(io::IO, cmd::Cmd)
             with_output_color(:underline, io) do io
                 print_shell_word(io, arg, shell_special)
             end
-        end, '`', "\\`")
+        end, '`' => "\\`")
     end, ' '))
     print(io, '`')
     print_env && (print(io, ","); show(io, cmd.env))