remove DirEntry path constructor. Improve docs

Author: IanButterworth

base/file.jl

@@ -954,21 +954,22 @@ const UV_DIRENT_BLOCK = Cint(7)
 
 A type representing a filesystem entry that contains the name of the entry, the directory, and
 the raw type of the entry. The full path of the entry can be obtained lazily by accessing the
-`path` field. The type of the entry can be checked for by calling [`isfile`](@ref), [`isdir`](@ref),
-[`islink`](@ref), [`isfifo`](@ref), [`issocket`](@ref), [`ischardev`](@ref), and [`isblockdev`](@ref).
+`path` field.
 
-If constructed manually via `DirEntry(path::String)`, the type of the entry is unknown and so `isfile`
-etc. will fall back to a `stat` call.
+Public fields:
+- `dir::String`: The directory containing the entry.
+- `name::String`: The name of the entry.
+- `path::String`: The full path of the entry, lazily constructed from `dir` and `name`. Also accessible via `joinpath(entry)`.
+
+The type of the entry can be checked for by calling [`isfile`](@ref), [`isdir`](@ref),
+[`islink`](@ref), [`isfifo`](@ref), [`issocket`](@ref), [`ischardev`](@ref), and [`isblockdev`](@ref)
+on the entry object.
 """
 struct DirEntry
     dir::String
     name::String
     rawtype::Cint
 end
-function DirEntry(path::String)
-    dir, name = splitdir(path)
-    return DirEntry(dir, name, UV_DIRENT_UNKNOWN)
-end
 function Base.getproperty(obj::DirEntry, p::Symbol)
     if p === :path
         return joinpath(obj.dir, obj.name)
@@ -1009,12 +1010,13 @@ object will be 0 (`UV_DIRENT_UNKNOWN`) and [`isfile`](@ref) etc. will fall back
 
 # Examples
 ```julia
-for obj in readdir(DirEntry, ".")
-    isfile(obj) && println("\$(obj.name) is a file with path \$(obj.path)")
-end
-for obj in readdir(DirEntry(path))
-    isdir(obj) || continue
-    for obj2 in readdir(obj)
+for entry in readdir(DirEntry, ".")
+    if isfile(entry)
+        println("\$(entry.name) is a file with path \$(entry.path)")
+        continue
+    end
+    isdir(entry) || continue
+    for entry2 in readdir(entry)
         ...
     end
 end

test/file.jl

@@ -31,15 +31,13 @@ end
     @test isdir("does/not/exist") == false
     @test_throws Base.IOError readdir("does/not/exist")
     @test_throws Base.IOError readdir(DirEntry, "does/not/exist")
-    @test_throws Base.IOError readdir(DirEntry("does/not/exist"))
 
     mktempdir() do dir
         touch(joinpath(dir, "afile.txt"))
         mkdir(joinpath(dir, "adir"))
         touch(joinpath(dir, "adir", "bfile.txt"))
         @test length(readdir(dir)) == 2
         @test readdir(dir) == map(e->e.name, readdir(DirEntry, dir))
-        @test readdir(DirEntry, dir) == readdir(DirEntry(dir))
         for p in readdir(dir, join=true)
             if isdir(p)
                 @test only(readdir(p)) == "bfile.txt"