Skip to content

Commit defa180

Browse files
authored
Update Quaternions.jl: missing * methods
1 parent 8b85f50 commit defa180

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

test/testhelpers/Quaternions.jl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,9 @@ Base.:(*)(q::Quaternion, w::Quaternion) = Quaternion(q.s*w.s - q.v1*w.v1 - q.v2*
3434
q.s*w.v2 - q.v1*w.v3 + q.v2*w.s + q.v3*w.v1,
3535
q.s*w.v3 + q.v1*w.v2 - q.v2*w.v1 + q.v3*w.s)
3636
Base.:(*)(q::Quaternion, r::Real) = Quaternion(q.s*r, q.v1*r, q.v2*r, q.v3*r)
37-
Base.:(*)(q::Quaternion, b::Bool) = b * q # remove method ambiguity
37+
Base.:(*)(q::Quaternion, r::Bool) = Quaternion(q.s*r, q.v1*r, q.v2*r, q.v3*r) # remove method ambiguity
38+
Base.:(*)(r::Real, q::Quaternion) = q * r
39+
Base.:(*)(r::Bool, q::Quaternion) = q * r # remove method ambiguity
3840
Base.:(/)(q::Quaternion, w::Quaternion) = q * conj(w) * (1.0 / abs2(w))
3941
Base.:(\)(q::Quaternion, w::Quaternion) = conj(q) * w * (1.0 / abs2(q))
4042

0 commit comments

Comments
 (0)